Skip to content

Commit

Permalink
drm: rcar-du: dsi: Improve DSI shutdown
Browse files Browse the repository at this point in the history
Improve the DSI shutdown procedure by clearing various bits that were
set while enabling the DSI output. There has been no clear issues caused
by these, but it's safer to ensure that the features are disabled at the
start of the next DSI enable.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
  • Loading branch information
tomba authored and intel-lab-lkp committed Aug 22, 2022
1 parent 5880005 commit 6479ac7
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -442,9 +442,21 @@ static int rcar_mipi_dsi_startup(struct rcar_mipi_dsi *dsi,

static void rcar_mipi_dsi_shutdown(struct rcar_mipi_dsi *dsi)
{
/* Disable VCLKEN */
rcar_mipi_dsi_clr(dsi, VCLKEN, VCLKEN_CKEN);

/* Disable DOT clock */
rcar_mipi_dsi_clr(dsi, VCLKSET, VCLKSET_CKEN);

rcar_mipi_dsi_clr(dsi, PHYSETUP, PHYSETUP_RSTZ);
rcar_mipi_dsi_clr(dsi, PHYSETUP, PHYSETUP_SHUTDOWNZ);

/* CFGCLK disable */
rcar_mipi_dsi_clr(dsi, CFGCLKSET, CFGCLKSET_CKEN);

/* LPCLK disable */
rcar_mipi_dsi_clr(dsi, LPCLKSET, LPCLKSET_CKEN);

dev_dbg(dsi->dev, "DSI device is shutdown\n");
}

Expand Down

0 comments on commit 6479ac7

Please sign in to comment.