Skip to content

Commit

Permalink
net: skb: prevent the split of kfree_skb_reason() by gcc
Browse files Browse the repository at this point in the history
Sometimes, gcc will optimize the function by spliting it to two or
more functions. In this case, kfree_skb_reason() is splited to
kfree_skb_reason and kfree_skb_reason.part.0. However, the
function/tracepoint trace_kfree_skb() in it needs the return address
of kfree_skb_reason().

This split makes the call chains becomes:
  kfree_skb_reason() -> kfree_skb_reason.part.0 -> trace_kfree_skb()

which makes the return address that passed to trace_kfree_skb() be
kfree_skb().

Therefore, prevent this kind of optimization to kfree_skb_reason() by
making the optimize level to "O1". I think these should be better
method instead of this "O1", but I can't figure it out......

This optimization CAN happen, which depend on the behavior of gcc.
I'm not able to reproduce it in the latest kernel code, but it happens
in my kernel of version 5.4.119. Maybe the latest code already do someting
that prevent this happen?

Signed-off-by: Menglong Dong <imagedong@tencent.com>
  • Loading branch information
xmmgithub authored and intel-lab-lkp committed Aug 11, 2022
1 parent f86d1fb commit 8e014b6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions include/linux/compiler_attributes.h
Expand Up @@ -371,4 +371,6 @@
*/
#define __weak __attribute__((__weak__))

#define __nofnsplit __attribute__((optimize("O1")))

#endif /* __LINUX_COMPILER_ATTRIBUTES_H */
3 changes: 2 additions & 1 deletion net/core/skbuff.c
Expand Up @@ -777,7 +777,8 @@ EXPORT_SYMBOL(__kfree_skb);
* hit zero. Meanwhile, pass the drop reason to 'kfree_skb'
* tracepoint.
*/
void kfree_skb_reason(struct sk_buff *skb, enum skb_drop_reason reason)
void __nofnsplit
kfree_skb_reason(struct sk_buff *skb, enum skb_drop_reason reason)
{
if (!skb_unref(skb))
return;
Expand Down

0 comments on commit 8e014b6

Please sign in to comment.