Skip to content

Commit

Permalink
iio: adc: mt6370: Fix ibus and ibat scaling value of some specific ve…
Browse files Browse the repository at this point in the history
…ndor ID chips

The scale value of ibus and ibat on the datasheet is incorrect due to the
customer report after the experimentation with some specific vendor ID
chips.

Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
  • Loading branch information
ChiaEn Wu authored and intel-lab-lkp committed Mar 24, 2023
1 parent 225dc61 commit 9822359
Showing 1 changed file with 46 additions and 2 deletions.
48 changes: 46 additions & 2 deletions drivers/iio/adc/mt6370-adc.c
Expand Up @@ -19,6 +19,7 @@

#include <dt-bindings/iio/adc/mediatek,mt6370_adc.h>

#define MT6370_REG_DEV_INFO 0x100
#define MT6370_REG_CHG_CTRL3 0x113
#define MT6370_REG_CHG_CTRL7 0x117
#define MT6370_REG_CHG_ADC 0x121
Expand All @@ -27,6 +28,7 @@
#define MT6370_ADC_START_MASK BIT(0)
#define MT6370_ADC_IN_SEL_MASK GENMASK(7, 4)
#define MT6370_AICR_ICHG_MASK GENMASK(7, 2)
#define MT6370_VENID_MASK GENMASK(7, 4)

#define MT6370_AICR_100_mA 0x0
#define MT6370_AICR_150_mA 0x1
Expand All @@ -47,6 +49,10 @@
#define ADC_CONV_TIME_MS 35
#define ADC_CONV_POLLING_TIME_US 1000

#define MT6370_VID_RT5081 0x8
#define MT6370_VID_RT5081A 0xA
#define MT6370_VID_MT6370 0xE

struct mt6370_adc_data {
struct device *dev;
struct regmap *regmap;
Expand All @@ -55,6 +61,7 @@ struct mt6370_adc_data {
* from being read at the same time.
*/
struct mutex adc_lock;
int vid;
};

static int mt6370_adc_read_channel(struct mt6370_adc_data *priv, int chan,
Expand Down Expand Up @@ -98,6 +105,26 @@ static int mt6370_adc_read_channel(struct mt6370_adc_data *priv, int chan,
return ret;
}

static int mt6370_adc_get_ibus_scale(struct mt6370_adc_data *priv)
{
if (priv->vid == MT6370_VID_RT5081 ||
priv->vid == MT6370_VID_RT5081A ||
priv->vid == MT6370_VID_MT6370)
return 3350;
else
return 3875;
}

static int mt6370_adc_get_ibat_scale(struct mt6370_adc_data *priv)
{
if (priv->vid == MT6370_VID_RT5081 ||
priv->vid == MT6370_VID_RT5081A ||
priv->vid == MT6370_VID_MT6370)
return 2680;
else
return 3870;
}

static int mt6370_adc_read_scale(struct mt6370_adc_data *priv,
int chan, int *val1, int *val2)
{
Expand All @@ -123,7 +150,7 @@ static int mt6370_adc_read_scale(struct mt6370_adc_data *priv,
case MT6370_AICR_250_mA:
case MT6370_AICR_300_mA:
case MT6370_AICR_350_mA:
*val1 = 3350;
*val1 = mt6370_adc_get_ibus_scale(priv);
break;
default:
*val1 = 5000;
Expand All @@ -150,7 +177,7 @@ static int mt6370_adc_read_scale(struct mt6370_adc_data *priv,
case MT6370_ICHG_600_mA:
case MT6370_ICHG_700_mA:
case MT6370_ICHG_800_mA:
*val1 = 2680;
*val1 = mt6370_adc_get_ibat_scale(priv);
break;
default:
*val1 = 5000;
Expand Down Expand Up @@ -251,6 +278,19 @@ static const struct iio_chan_spec mt6370_adc_channels[] = {
MT6370_ADC_CHAN(TEMP_JC, IIO_TEMP, 12, BIT(IIO_CHAN_INFO_OFFSET)),
};

static int mt6370_get_vendor_info(struct mt6370_adc_data *priv)
{
unsigned int dev_info;
int ret;

ret = regmap_read(priv->regmap, MT6370_REG_DEV_INFO, &dev_info);
if (ret)
return ret;

priv->vid = FIELD_GET(MT6370_VENID_MASK, dev_info);
return 0;
}

static int mt6370_adc_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
Expand All @@ -263,6 +303,10 @@ static int mt6370_adc_probe(struct platform_device *pdev)
if (!regmap)
return dev_err_probe(dev, -ENODEV, "Failed to get regmap\n");

ret = mt6370_get_vendor_info(priv);
if (ret)
return dev_err_probe(dev, ret, "Failed to get vid\n");

indio_dev = devm_iio_device_alloc(dev, sizeof(*priv));
if (!indio_dev)
return -ENOMEM;
Expand Down

0 comments on commit 9822359

Please sign in to comment.