Skip to content

Commit

Permalink
dmaengine: mv_xor_v2 : Move spin_lock_bh() to spin_lock()
Browse files Browse the repository at this point in the history
It is unnecessary to call spin_lock_bh() for that you are already
in a tasklet.

Signed-off-by: Yunbo Yu <yuyunbo519@gmail.com>
Link: https://lore.kernel.org/r/20220420122754.148359-1-yuyunbo519@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
  • Loading branch information
luteresa authored and vinodkoul committed Apr 22, 2022
1 parent 63c14ae commit 99faef4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/dma/mv_xor_v2.c
Expand Up @@ -591,14 +591,14 @@ static void mv_xor_v2_tasklet(struct tasklet_struct *t)
dma_run_dependencies(&next_pending_sw_desc->async_tx);

/* Lock the channel */
spin_lock_bh(&xor_dev->lock);
spin_lock(&xor_dev->lock);

/* add the SW descriptor to the free descriptors list */
list_add(&next_pending_sw_desc->free_list,
&xor_dev->free_sw_desc);

/* Release the channel */
spin_unlock_bh(&xor_dev->lock);
spin_unlock(&xor_dev->lock);

/* increment the next descriptor */
pending_ptr++;
Expand Down

0 comments on commit 99faef4

Please sign in to comment.