Skip to content

Commit

Permalink
fbdev: Use of_property_present() for testing DT property presence
Browse files Browse the repository at this point in the history
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
  • Loading branch information
robherring authored and intel-lab-lkp committed Mar 10, 2023
1 parent 3e853b9 commit c013f41
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/video/fbdev/amba-clcd.c
Expand Up @@ -854,7 +854,7 @@ static struct clcd_board *clcdfb_of_get_board(struct amba_device *dev)
board->caps = CLCD_CAP_ALL;
board->check = clcdfb_check;
board->decode = clcdfb_decode;
if (of_find_property(node, "memory-region", NULL)) {
if (of_property_present(node, "memory-region")) {
board->setup = clcdfb_of_vram_setup;
board->mmap = clcdfb_of_vram_mmap;
board->remove = clcdfb_of_vram_remove;
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/fbdev/bw2.c
Expand Up @@ -306,7 +306,7 @@ static int bw2_probe(struct platform_device *op)
if (!par->regs)
goto out_release_fb;

if (!of_find_property(dp, "width", NULL)) {
if (!of_property_present(dp, "width")) {
err = bw2_do_default_mode(par, info, &linebytes);
if (err)
goto out_unmap_regs;
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/fbdev/cg3.c
Expand Up @@ -393,7 +393,7 @@ static int cg3_probe(struct platform_device *op)

cg3_blank(FB_BLANK_UNBLANK, info);

if (!of_find_property(dp, "width", NULL)) {
if (!of_property_present(dp, "width")) {
err = cg3_do_default_mode(par);
if (err)
goto out_unmap_screen;
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c
Expand Up @@ -192,7 +192,7 @@ static int __init omapdss_boot_init(void)
omapdss_walk_device(dss, true);

for_each_available_child_of_node(dss, child) {
if (!of_find_property(child, "compatible", NULL))
if (!of_property_present(child, "compatible"))
continue;

omapdss_walk_device(child, true);
Expand Down

0 comments on commit c013f41

Please sign in to comment.