Skip to content

Commit

Permalink
drm: debugfs: provide infrastructure to dump a DRM GPU VA space
Browse files Browse the repository at this point in the history
This commit adds a function to dump a DRM GPU VA space and a macro for
drivers to register the struct drm_info_list 'gpuvas' entry.

Most likely, most drivers might maintain one DRM GPU VA space per struct
drm_file, but there might also be drivers not having a fixed relation
between DRM GPU VA spaces and a DRM core infrastructure, hence we need the
indirection via the driver iterating it's maintained DRM GPU VA spaces.

Signed-off-by: Danilo Krummrich <dakr@redhat.com>
  • Loading branch information
dakr authored and intel-lab-lkp committed Feb 17, 2023
1 parent 00132cc commit e1a1c96
Show file tree
Hide file tree
Showing 2 changed files with 81 additions and 0 deletions.
56 changes: 56 additions & 0 deletions drivers/gpu/drm/drm_debugfs.c
Expand Up @@ -39,6 +39,7 @@
#include <drm/drm_file.h>
#include <drm/drm_gem.h>
#include <drm/drm_managed.h>
#include <drm/drm_gpuva_mgr.h>

#include "drm_crtc_internal.h"
#include "drm_internal.h"
Expand Down Expand Up @@ -175,6 +176,61 @@ static const struct file_operations drm_debugfs_fops = {
.release = single_release,
};

/**
* drm_debugfs_gpuva_info - dump the given DRM GPU VA space
* @m: pointer to the &seq_file to write
* @mgr: the &drm_gpuva_manager representing the GPU VA space
*
* Dumps the GPU VA regions and mappings of a given DRM GPU VA manager.
*
* For each DRM GPU VA space drivers should call this function from their
* &drm_info_list's show callback.
*
* Returns: 0 on success, -ENODEV if the &mgr is not initialized
*/
int drm_debugfs_gpuva_info(struct seq_file *m,
struct drm_gpuva_manager *mgr)
{
DRM_GPUVA_ITER(it, mgr);
DRM_GPUVA_REGION_ITER(__it, mgr);

if (!mgr->name)
return -ENODEV;

seq_printf(m, "DRM GPU VA space (%s)\n", mgr->name);
seq_puts (m, "\n");
seq_puts (m, " VA regions | start | range | end | sparse\n");
seq_puts (m, "------------------------------------------------------------------------------------\n");
seq_printf(m, " VA space | 0x%016llx | 0x%016llx | 0x%016llx | -\n",
mgr->mm_start, mgr->mm_range, mgr->mm_start + mgr->mm_range);
seq_puts (m, "-----------------------------------------------------------------------------------\n");
drm_gpuva_iter_for_each(__it) {
struct drm_gpuva_region *reg = __it.reg;

if (reg == &mgr->kernel_alloc_region) {
seq_printf(m, " kernel node | 0x%016llx | 0x%016llx | 0x%016llx | -\n",
reg->va.addr, reg->va.range, reg->va.addr + reg->va.range);
continue;
}

seq_printf(m, " | 0x%016llx | 0x%016llx | 0x%016llx | %s\n",
reg->va.addr, reg->va.range, reg->va.addr + reg->va.range,
reg->sparse ? "true" : "false");
}
seq_puts(m, "\n");
seq_puts(m, " VAs | start | range | end | object | object offset\n");
seq_puts(m, "-------------------------------------------------------------------------------------------------------------\n");
drm_gpuva_iter_for_each(it) {
struct drm_gpuva *va = it.va;

seq_printf(m, " | 0x%016llx | 0x%016llx | 0x%016llx | 0x%016llx | 0x%016llx\n",
va->va.addr, va->va.range, va->va.addr + va->va.range,
(u64)va->gem.obj, va->gem.offset);
}

return 0;
}
EXPORT_SYMBOL(drm_debugfs_gpuva_info);

/**
* drm_debugfs_create_files - Initialize a given set of debugfs files for DRM
Expand Down
25 changes: 25 additions & 0 deletions include/drm/drm_debugfs.h
Expand Up @@ -34,6 +34,22 @@

#include <linux/types.h>
#include <linux/seq_file.h>

#include <drm/drm_gpuva_mgr.h>

/**
* DRM_DEBUGFS_GPUVA_INFO - &drm_info_list entry to dump a GPU VA space
* @show: the &drm_info_list's show callback
* @data: driver private data
*
* Drivers should use this macro to define a &drm_info_list entry to provide a
* debugfs file for dumping the GPU VA space regions and mappings.
*
* For each DRM GPU VA space drivers should call drm_debugfs_gpuva_info() from
* their @show callback.
*/
#define DRM_DEBUGFS_GPUVA_INFO(show, data) {"gpuvas", show, DRIVER_GEM_GPUVA, data}

/**
* struct drm_info_list - debugfs info list entry
*
Expand Down Expand Up @@ -134,6 +150,9 @@ void drm_debugfs_add_file(struct drm_device *dev, const char *name,

void drm_debugfs_add_files(struct drm_device *dev,
const struct drm_debugfs_info *files, int count);

int drm_debugfs_gpuva_info(struct seq_file *m,
struct drm_gpuva_manager *mgr);
#else
static inline void drm_debugfs_create_files(const struct drm_info_list *files,
int count, struct dentry *root,
Expand All @@ -155,6 +174,12 @@ static inline void drm_debugfs_add_files(struct drm_device *dev,
const struct drm_debugfs_info *files,
int count)
{}

static inline int drm_debugfs_gpuva_info(struct seq_file *m,
struct drm_gpuva_manager *mgr)
{
return 0;
}
#endif

#endif /* _DRM_DEBUGFS_H_ */

0 comments on commit e1a1c96

Please sign in to comment.