forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
drivers: base: Add basic devm tests for root devices
The root devices show some odd behaviours compared to regular "bus" devices that have been probed through the usual mechanism, so let's create kunit tests to exercise those paths and odd cases. Signed-off-by: Maxime Ripard <maxime@cerno.tech>
- Loading branch information
1 parent
a6faf7e
commit f685d9f
Showing
4 changed files
with
128 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
CONFIG_KUNIT=y | ||
CONFIG_DM_KUNIT_TEST=y |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
# SPDX-License-Identifier: GPL-2.0 | ||
obj-$(CONFIG_TEST_ASYNC_DRIVER_PROBE) += test_async_driver_probe.o | ||
|
||
obj-$(CONFIG_DM_KUNIT_TEST) += root-device-test.o | ||
|
||
obj-$(CONFIG_DRIVER_PE_KUNIT_TEST) += property-entry-test.o | ||
CFLAGS_property-entry-test.o += $(DISABLE_STRUCTLEAK_PLUGIN) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,120 @@ | ||
// SPDX-License-Identifier: GPL-2.0 | ||
// Copyright 2023 Maxime Ripard <mripard@kernel.org> | ||
|
||
#include <kunit/resource.h> | ||
|
||
#include <linux/device.h> | ||
|
||
#define DEVICE_NAME "test" | ||
|
||
struct test_priv { | ||
bool probe_done; | ||
bool release_done; | ||
wait_queue_head_t release_wq; | ||
struct device *dev; | ||
}; | ||
|
||
static void devm_device_action(void *ptr) | ||
{ | ||
struct test_priv *priv = ptr; | ||
|
||
priv->release_done = true; | ||
wake_up_interruptible(&priv->release_wq); | ||
} | ||
|
||
static void devm_put_device_action(void *ptr) | ||
{ | ||
struct test_priv *priv = ptr; | ||
|
||
put_device(priv->dev); | ||
priv->release_done = true; | ||
wake_up_interruptible(&priv->release_wq); | ||
} | ||
|
||
#define RELEASE_TIMEOUT_MS 500 | ||
|
||
static void root_device_devm_register_unregister_test(struct kunit *test) | ||
{ | ||
struct test_priv *priv; | ||
int ret; | ||
|
||
priv = kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL); | ||
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv); | ||
init_waitqueue_head(&priv->release_wq); | ||
|
||
priv->dev = root_device_register(DEVICE_NAME); | ||
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv->dev); | ||
|
||
ret = devm_add_action_or_reset(priv->dev, devm_device_action, priv); | ||
KUNIT_ASSERT_EQ(test, ret, 0); | ||
|
||
root_device_unregister(priv->dev); | ||
|
||
ret = wait_event_interruptible_timeout(priv->release_wq, priv->release_done, | ||
msecs_to_jiffies(RELEASE_TIMEOUT_MS)); | ||
KUNIT_EXPECT_GT(test, ret, 0); | ||
} | ||
|
||
static void root_device_devm_register_get_put_unregister_test(struct kunit *test) | ||
{ | ||
struct test_priv *priv; | ||
int ret; | ||
|
||
priv = kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL); | ||
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv); | ||
init_waitqueue_head(&priv->release_wq); | ||
|
||
priv->dev = root_device_register(DEVICE_NAME); | ||
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv->dev); | ||
|
||
get_device(priv->dev); | ||
|
||
ret = devm_add_action_or_reset(priv->dev, devm_device_action, priv); | ||
KUNIT_ASSERT_EQ(test, ret, 0); | ||
|
||
put_device(priv->dev); | ||
|
||
root_device_unregister(priv->dev); | ||
|
||
ret = wait_event_interruptible_timeout(priv->release_wq, priv->release_done, | ||
msecs_to_jiffies(RELEASE_TIMEOUT_MS)); | ||
KUNIT_EXPECT_GT(test, ret, 0); | ||
} | ||
|
||
static void root_device_devm_register_get_unregister_with_devm_test(struct kunit *test) | ||
{ | ||
struct test_priv *priv; | ||
int ret; | ||
|
||
priv = kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL); | ||
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv); | ||
init_waitqueue_head(&priv->release_wq); | ||
|
||
priv->dev = root_device_register(DEVICE_NAME); | ||
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv->dev); | ||
|
||
get_device(priv->dev); | ||
|
||
ret = devm_add_action_or_reset(priv->dev, devm_put_device_action, priv); | ||
KUNIT_ASSERT_EQ(test, ret, 0); | ||
|
||
root_device_unregister(priv->dev); | ||
|
||
ret = wait_event_interruptible_timeout(priv->release_wq, priv->release_done, | ||
msecs_to_jiffies(RELEASE_TIMEOUT_MS)); | ||
KUNIT_EXPECT_GT(test, ret, 0); | ||
} | ||
|
||
static struct kunit_case root_device_devm_tests[] = { | ||
KUNIT_CASE(root_device_devm_register_unregister_test), | ||
KUNIT_CASE(root_device_devm_register_get_put_unregister_test), | ||
KUNIT_CASE(root_device_devm_register_get_unregister_with_devm_test), | ||
{} | ||
}; | ||
|
||
static struct kunit_suite root_device_devm_test_suite = { | ||
.name = "root-device-devm", | ||
.test_cases = root_device_devm_tests, | ||
}; | ||
|
||
kunit_test_suite(root_device_devm_test_suite); |