Skip to content

Commit

Permalink
cachestat: implement cachestat syscall
Browse files Browse the repository at this point in the history
There is currently no good way to query the page cache state of large
file sets and directory trees. There is mincore(), but it scales poorly:
the kernel writes out a lot of bitmap data that userspace has to
aggregate, when the user really doesn not care about per-page
information in that case. The user also needs to mmap and unmap each
file as it goes along, which can be quite slow as well.

This patch implements a new syscall that queries cache state of a file
and summarizes the number of cached pages, number of dirty pages, number
of pages marked for writeback, number of (recently) evicted pages, etc.
in a given range.

NAME
    cachestat - query the page cache statistics of a file.

SYNOPSIS
    #include <sys/mman.h>

    struct cachestat {
        __u64 nr_cache;
        __u64 nr_dirty;
        __u64 nr_writeback;
        __u64 nr_evicted;
        __u64 nr_recently_evicted;
    };

    int cachestat(unsigned int fd, off_t off, size_t len,
          unsigned int cstat_version, struct cachestat *cstat,
          unsigned int flags);

DESCRIPTION
    cachestat() queries the number of cached pages, number of dirty
    pages, number of pages marked for writeback, number of evicted
    pages, number of recently evicted pages, in the bytes range given by
    `off` and `len`.

    An evicted page is a page that is previously in the page cache but
    has been evicted since. A page is recently evicted if its last
    eviction was recent enough that its reentry to the cache would
    indicate that it is actively being used by the system, and that
    there is memory pressure on the system.

    These values are returned in a cachestat struct, whose address is
    given by the `cstat` argument.

    The `off` and `len` arguments must be non-negative integers. If
    `len` > 0, the queried range is [`off`, `off` + `len`]. If `len` ==
    0, we will query in the range from `off` to the end of the file.

    `cstat_version` is an unsigned integer indicating the specific
    version of the cachestat struct. It must be at least 1, and does
    not exceed the latest version number (which is currently 1). For
    now, user should just pass 1.

    The `flags` argument is unused for now, but is included for future
    extensibility. User should pass 0 (i.e no flag specified).

RETURN VALUE
    On success, cachestat returns 0. On error, -1 is returned, and errno
    is set to indicate the error.

ERRORS
    EFAULT cstat points to an invalid address.

    EINVAL invalid `cstat_version` or `flags`

    EBADF  invalid file descriptor.

Signed-off-by: Nhat Pham <nphamcs@gmail.com>
  • Loading branch information
nhatsmrt authored and intel-lab-lkp committed Jan 24, 2023
1 parent af8b81a commit f902a36
Show file tree
Hide file tree
Showing 20 changed files with 198 additions and 1 deletion.
1 change: 1 addition & 0 deletions arch/alpha/kernel/syscalls/syscall.tbl
Expand Up @@ -490,3 +490,4 @@
558 common process_mrelease sys_process_mrelease
559 common futex_waitv sys_futex_waitv
560 common set_mempolicy_home_node sys_ni_syscall
561 common cachestat sys_cachestat
1 change: 1 addition & 0 deletions arch/arm/tools/syscall.tbl
Expand Up @@ -464,3 +464,4 @@
448 common process_mrelease sys_process_mrelease
449 common futex_waitv sys_futex_waitv
450 common set_mempolicy_home_node sys_set_mempolicy_home_node
451 common cachestat sys_cachestat
1 change: 1 addition & 0 deletions arch/ia64/kernel/syscalls/syscall.tbl
Expand Up @@ -371,3 +371,4 @@
448 common process_mrelease sys_process_mrelease
449 common futex_waitv sys_futex_waitv
450 common set_mempolicy_home_node sys_set_mempolicy_home_node
451 common cachestat sys_cachestat
1 change: 1 addition & 0 deletions arch/m68k/kernel/syscalls/syscall.tbl
Expand Up @@ -450,3 +450,4 @@
448 common process_mrelease sys_process_mrelease
449 common futex_waitv sys_futex_waitv
450 common set_mempolicy_home_node sys_set_mempolicy_home_node
451 common cachestat sys_cachestat
1 change: 1 addition & 0 deletions arch/microblaze/kernel/syscalls/syscall.tbl
Expand Up @@ -456,3 +456,4 @@
448 common process_mrelease sys_process_mrelease
449 common futex_waitv sys_futex_waitv
450 common set_mempolicy_home_node sys_set_mempolicy_home_node
451 common cachestat sys_cachestat
1 change: 1 addition & 0 deletions arch/parisc/kernel/syscalls/syscall.tbl
Expand Up @@ -448,3 +448,4 @@
448 common process_mrelease sys_process_mrelease
449 common futex_waitv sys_futex_waitv
450 common set_mempolicy_home_node sys_set_mempolicy_home_node
451 common cachestat sys_cachestat
1 change: 1 addition & 0 deletions arch/powerpc/kernel/syscalls/syscall.tbl
Expand Up @@ -530,3 +530,4 @@
448 common process_mrelease sys_process_mrelease
449 common futex_waitv sys_futex_waitv
450 nospu set_mempolicy_home_node sys_set_mempolicy_home_node
451 common cachestat sys_cachestat
1 change: 1 addition & 0 deletions arch/s390/kernel/syscalls/syscall.tbl
Expand Up @@ -453,3 +453,4 @@
448 common process_mrelease sys_process_mrelease sys_process_mrelease
449 common futex_waitv sys_futex_waitv sys_futex_waitv
450 common set_mempolicy_home_node sys_set_mempolicy_home_node sys_set_mempolicy_home_node
451 common cachestat sys_cachestat sys_cachestat
1 change: 1 addition & 0 deletions arch/sh/kernel/syscalls/syscall.tbl
Expand Up @@ -453,3 +453,4 @@
448 common process_mrelease sys_process_mrelease
449 common futex_waitv sys_futex_waitv
450 common set_mempolicy_home_node sys_set_mempolicy_home_node
451 common cachestat sys_cachestat
1 change: 1 addition & 0 deletions arch/sparc/kernel/syscalls/syscall.tbl
Expand Up @@ -496,3 +496,4 @@
448 common process_mrelease sys_process_mrelease
449 common futex_waitv sys_futex_waitv
450 common set_mempolicy_home_node sys_set_mempolicy_home_node
451 common cachestat sys_cachestat
1 change: 1 addition & 0 deletions arch/x86/entry/syscalls/syscall_32.tbl
Expand Up @@ -455,3 +455,4 @@
448 i386 process_mrelease sys_process_mrelease
449 i386 futex_waitv sys_futex_waitv
450 i386 set_mempolicy_home_node sys_set_mempolicy_home_node
451 i386 cachestat sys_cachestat
1 change: 1 addition & 0 deletions arch/x86/entry/syscalls/syscall_64.tbl
Expand Up @@ -372,6 +372,7 @@
448 common process_mrelease sys_process_mrelease
449 common futex_waitv sys_futex_waitv
450 common set_mempolicy_home_node sys_set_mempolicy_home_node
451 common cachestat sys_cachestat

#
# Due to a historical design error, certain syscalls are numbered differently
Expand Down
1 change: 1 addition & 0 deletions arch/xtensa/kernel/syscalls/syscall.tbl
Expand Up @@ -421,3 +421,4 @@
448 common process_mrelease sys_process_mrelease
449 common futex_waitv sys_futex_waitv
450 common set_mempolicy_home_node sys_set_mempolicy_home_node
451 common cachestat sys_cachestat
3 changes: 3 additions & 0 deletions include/linux/fs.h
Expand Up @@ -75,6 +75,7 @@ struct fs_context;
struct fs_parameter_spec;
struct fileattr;
struct iomap_ops;
struct cachestat;

extern void __init inode_init(void);
extern void __init inode_init_early(void);
Expand Down Expand Up @@ -830,6 +831,8 @@ void filemap_invalidate_lock_two(struct address_space *mapping1,
struct address_space *mapping2);
void filemap_invalidate_unlock_two(struct address_space *mapping1,
struct address_space *mapping2);
void filemap_cachestat(struct address_space *mapping, pgoff_t first_index,
pgoff_t last_index, struct cachestat *cs);


/*
Expand Down
4 changes: 4 additions & 0 deletions include/linux/syscalls.h
Expand Up @@ -72,6 +72,7 @@ struct open_how;
struct mount_attr;
struct landlock_ruleset_attr;
enum landlock_rule_type;
struct cachestat;

#include <linux/types.h>
#include <linux/aio_abi.h>
Expand Down Expand Up @@ -1056,6 +1057,9 @@ asmlinkage long sys_memfd_secret(unsigned int flags);
asmlinkage long sys_set_mempolicy_home_node(unsigned long start, unsigned long len,
unsigned long home_node,
unsigned long flags);
asmlinkage long sys_cachestat(unsigned int fd, off_t off, size_t len,
unsigned int cstat_version, struct cachestat __user *cstat,
unsigned int flags);

/*
* Architecture-specific system calls
Expand Down
5 changes: 4 additions & 1 deletion include/uapi/asm-generic/unistd.h
Expand Up @@ -886,8 +886,11 @@ __SYSCALL(__NR_futex_waitv, sys_futex_waitv)
#define __NR_set_mempolicy_home_node 450
__SYSCALL(__NR_set_mempolicy_home_node, sys_set_mempolicy_home_node)

#define __NR_cachestat 451
__SYSCALL(__NR_cachestat, sys_cachestat)

#undef __NR_syscalls
#define __NR_syscalls 451
#define __NR_syscalls 452

/*
* 32 bit systems traditionally used different
Expand Down
9 changes: 9 additions & 0 deletions include/uapi/linux/mman.h
Expand Up @@ -4,6 +4,7 @@

#include <asm/mman.h>
#include <asm-generic/hugetlb_encode.h>
#include <linux/types.h>

#define MREMAP_MAYMOVE 1
#define MREMAP_FIXED 2
Expand Down Expand Up @@ -41,4 +42,12 @@
#define MAP_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
#define MAP_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB

struct cachestat {
__u64 nr_cache;
__u64 nr_dirty;
__u64 nr_writeback;
__u64 nr_evicted;
__u64 nr_recently_evicted;
};

#endif /* _UAPI_LINUX_MMAN_H */
10 changes: 10 additions & 0 deletions init/Kconfig
Expand Up @@ -1798,6 +1798,16 @@ config RSEQ

If unsure, say Y.

config CACHESTAT_SYSCALL
bool "Enable cachestat() system call" if EXPERT
default y
help
Enable the cachestat system call, which queries the page cache
statistics of a file (number of cached pages, dirty pages,
pages marked for writeback, (recently) evicted pages).

If unsure say Y here.

config DEBUG_RSEQ
default n
bool "Enabled debugging of rseq() system call" if EXPERT
Expand Down
1 change: 1 addition & 0 deletions kernel/sys_ni.c
Expand Up @@ -299,6 +299,7 @@ COND_SYSCALL(set_mempolicy);
COND_SYSCALL(migrate_pages);
COND_SYSCALL(move_pages);
COND_SYSCALL(set_mempolicy_home_node);
COND_SYSCALL(cachestat);

COND_SYSCALL(perf_event_open);
COND_SYSCALL(accept4);
Expand Down
154 changes: 154 additions & 0 deletions mm/filemap.c
Expand Up @@ -22,6 +22,7 @@
#include <linux/mm.h>
#include <linux/swap.h>
#include <linux/swapops.h>
#include <linux/syscalls.h>
#include <linux/mman.h>
#include <linux/pagemap.h>
#include <linux/file.h>
Expand Down Expand Up @@ -55,6 +56,13 @@
#include <linux/buffer_head.h> /* for try_to_free_buffers */

#include <asm/mman.h>
#include <uapi/linux/mman.h>

#include "swap.h"

#ifdef CONFIG_CACHESTAT_SYSCALL
#define LATEST_CACHESTAT_VERSION 1
#endif

/*
* Shared mappings implemented 30.11.1994. It's not fully working yet,
Expand Down Expand Up @@ -3949,3 +3957,149 @@ bool filemap_release_folio(struct folio *folio, gfp_t gfp)
return try_to_free_buffers(folio);
}
EXPORT_SYMBOL(filemap_release_folio);

/**
* filemap_cachestat() - compute the page cache statistics of a mapping
* @mapping: The mapping to compute the statistics for.
* @first_index: The starting page cache index.
* @last_index: The final page index (inclusive).
* @cs: the cachestat struct to write the result to.
*
* This will query the page cache statistics of a mapping in the
* page range of [first_index, last_index] (inclusive). The statistics
* queried include: number of dirty pages, number of pages marked for
* writeback, and the number of (recently) evicted pages.
*/
void filemap_cachestat(struct address_space *mapping, pgoff_t first_index,
pgoff_t last_index, struct cachestat *cs)
{
XA_STATE(xas, &mapping->i_pages, first_index);
struct folio *folio;

rcu_read_lock();
xas_for_each(&xas, folio, last_index) {
unsigned long nr_pages;
pgoff_t folio_first_index, folio_last_index;

if (xas_retry(&xas, folio))
continue;

nr_pages = folio_nr_pages(folio);
folio_first_index = folio_pgoff(folio);
folio_last_index = folio_first_index + nr_pages - 1;

/* Folios might straddle the range boundaries, only count covered subpages */
if (folio_first_index < first_index)
nr_pages -= first_index - folio_first_index;

if (folio_last_index > last_index)
nr_pages -= folio_last_index - last_index;

if (xa_is_value(folio)) {
/* page is evicted */
void *shadow = (void *)folio;
bool workingset; /* not used */

cs->nr_evicted += nr_pages;

#ifdef CONFIG_SWAP /* implies CONFIG_MMU */
if (shmem_mapping(mapping)) {
/* shmem file - in swap cache */
swp_entry_t swp = radix_to_swp_entry(folio);

shadow = get_shadow_from_swap_cache(swp);
}
#endif
if (workingset_test_recent(shadow, true, &workingset))
cs->nr_recently_evicted += nr_pages;

goto resched;
}

/* page is in cache */
cs->nr_cache += nr_pages;

if (folio_test_dirty(folio))
cs->nr_dirty += nr_pages;

if (folio_test_writeback(folio))
cs->nr_writeback += nr_pages;

resched:
if (need_resched()) {
xas_pause(&xas);
cond_resched_rcu();
}
}
rcu_read_unlock();
}
EXPORT_SYMBOL(filemap_cachestat);

#ifdef CONFIG_CACHESTAT_SYSCALL
/*
* The cachestat(5) system call.
*
* cachestat() returns the page cache statistics of a file in the
* bytes range specified by `off` and `len`: number of cached pages,
* number of dirty pages, number of pages marked for writeback,
* number of evicted pages, and number of recently evicted pages.
*
* An evicted page is a page that is previously in the page cache
* but has been evicted since. A page is recently evicted if its last
* eviction was recent enough that its reentry to the cache would
* indicate that it is actively being used by the system, and that
* there is memory pressure on the system.
*
* `off` and `len` must be non-negative integers. If `len` > 0,
* the queried range is [`off`, `off` + `len`]. If `len` == 0,
* we will query in the range from `off` to the end of the file.
*
* `cstat_version` is an unsigned integer indicating the specific version
* of the cachestat struct. It must be at least 1, and does not exceed the
* latest version number (which is currently 1). For now, user should
* just pass 1.
*
* The `flags` argument is unused for now, but is included for future
* extensibility. User should pass 0 (i.e no flag specified).
*
* Because the status of a page can change after cachestat() checks it
* but before it returns to the application, the returned values may
* contain stale information.
*
* return values:
* zero - success
* -EFAULT - cstat points to an illegal address
* -EINVAL - invalid arguments
* -EBADF - invalid file descriptor
*/
SYSCALL_DEFINE6(cachestat, unsigned int, fd, off_t, off, size_t, len,
unsigned int, cstat_version, struct cachestat __user *, cstat,
unsigned int, flags)
{
struct fd f = fdget(fd);
struct address_space *mapping;
struct cachestat cs;
pgoff_t first_index = off >> PAGE_SHIFT;
pgoff_t last_index =
len == 0 ? ULONG_MAX : (off + len - 1) >> PAGE_SHIFT;

if (!f.file)
return -EBADF;

if (off < 0 || flags != 0 || cstat_version < 1 ||
cstat_version > LATEST_CACHESTAT_VERSION) {
fdput(f);
return -EINVAL;
}

memset(&cs, 0, sizeof(struct cachestat));
mapping = f.file->f_mapping;
filemap_cachestat(mapping, first_index, last_index, &cs);
fdput(f);

if (copy_to_user(cstat, &cs, sizeof(struct cachestat)))
return -EFAULT;

return 0;
}
#endif /* CONFIG_CACHESTAT_SYSCALL */

0 comments on commit f902a36

Please sign in to comment.