feat: add controller to as-controller-board-status #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes: issue intel-retail#40 Signed-off-by: Valina Li <valina.li@intel.com>
vli11
requested review from
lenny-goodell,
brian-intel,
jim-wang-intel,
joshua-silverio and
marcpfuller
|
|
||
| func (c *Controller) AddAllRoutes() error { | ||
| // Add the "status" REST API route | ||
| err := c.service.AddRoute("/status", c.GetStatus, "GET", "OPTIONS") |
There was a problem hiding this comment.
http.MethodGet, http.MethodOptions for constants
lenny-goodell
suggested changes
Sep 21, 2022
| @@ -6,7 +6,7 @@ package functions | |||
| import ( | |||
| "time" | |||
|
|
|||
| "github.com/edgexfoundry/app-functions-sdk-go/v2/pkg/interfaces" | |||
| clientInterfaces "github.com/edgexfoundry/go-mod-core-contracts/v2/clients/interfaces" | |||
There was a problem hiding this comment.
go convention is to only alias when you have a name conflict, which isn't the case here
as-controller-board-status/main.go
Outdated
| SubscriptionClient: subscriptionClient, | ||
| } | ||
|
|
||
| // Subscribe to the EdgeX notification service |
There was a problem hiding this comment.
Remove command since this is obvious from the code.
jim-wang-intel
requested changes
Sep 21, 2022
Signed-off-by: Valina Li <valina.li@intel.com>
jim-wang-intel
requested changes
Sep 21, 2022
lenny-goodell
suggested changes
Sep 21, 2022
Comment on lines
15
to
20
| // RESTPost is a const used for REST commands using the specified method. | ||
| RESTPost = "POST" | ||
| RESTPost = http.MethodPost | ||
| // RESTPut is a const used for REST commands using the specified method. | ||
| RESTPut = "PUT" | ||
| RESTPut = http.MethodPut | ||
| // RESTGet is a const used for REST commands using the specified method. | ||
| RESTGet = "GET" | ||
| RESTGet = http.MethodGet |
There was a problem hiding this comment.
Just remove these constants and use the ones from http. in place of them
jim-wang-intel
approved these changes
Sep 21, 2022
Signed-off-by: Valina Li <valina.li@intel.com>
| utilities.WriteJSONHTTPResponse(writer, req, http.StatusOK, controllerBoardStatusJSON, false) | ||
| }) | ||
| // for testing purpose | ||
| func (boardStatus *CheckBoardStatus) SetControllerBoardStatus(controllerBoardStatusInput ControllerBoardStatus) { |
There was a problem hiding this comment.
Actually Set is not needed for testing since as @jim-wang-intel pointed out the tests have direct access to controllerBoardStatusInput . This can be cleaned up in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: issue #40
Signed-off-by: Valina Li valina.li@intel.com