fix: refactored as-vending to use custom config instead of marshallSe… #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttings. This partly closes intel-retail#44 Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>
marcpfuller
requested review from
vli11,
jim-wang-intel,
lenny-goodell,
brian-intel and
joshua-silverio
lenny-goodell
suggested changes
Sep 22, 2022
brian-intel
reviewed
Sep 22, 2022
Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>
…ttings. This partly closes intel-retail#44 Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>
Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>
Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>
marcpfuller
force-pushed
the
as-vending_custom_config
branch
from
90b8d9f
to
07a6e1c
Compare
…ller/automated-checkout into as-vending_custom_config Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>
marcpfuller
force-pushed
the
as-vending_custom_config
branch
from
07a6e1c
to
799aaa5
Compare
brian-intel
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactored as-vending to use custom config instead of marshallSettings. This partly closes #44
Signed-off-by: Marc-Philippe Fuller marc-philippe.fuller@intel.com