Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaneDirection estimation in RssObjectPositionExtractor::newLaneSegment #106

Closed
xiaong opened this issue May 21, 2021 · 2 comments
Closed

Comments

@xiaong
Copy link

xiaong commented May 21, 2021

One question for positive lane or negative lane estimation logic:
In RssObjectPositionExtractor::newLaneSegment the object lane direction is gotten from laneSegment laneDrivingDirection. But if the object is occupying both positive and negtive lane, the lane type will be overwritten by the last occupied laneSegment. Will there be a logic bug?

if (laneSegment.drivingDirection == LaneDrivingDirection::Positive)
      {
        mObjectDimensions.onPositiveLane = true;
      }

      if (laneSegment.drivingDirection == LaneDrivingDirection::Negative)
      {
        mObjectDimensions.onNegativeLane = true;
      }

THX!

@berndgassmann
Copy link
Contributor

Hi,
this function is collecting both information, because it's collecting onPositiveLane as well as onNegativeLane flag. At this place nothing is overwritten. In case the vehicle is touching both kind of lanes, both flags are true.

That information is later used to determine if the the vehicle is in respect to the current situation actually on the correct lane or not by filling the isInCorrectLane flag for Non-Intersection-Cases and for Intersection cases.
In general isInCorrectLane flag is only relevant in the opposite use-case to distinguish between BrakeMin and BrakeMinCorrect expected braking deceleration.

I hope this answers your question and clears your doubts.

@xiaong
Copy link
Author

xiaong commented May 24, 2021

Got it. Thank you for your answer!

@xiaong xiaong closed this as completed May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants