This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Feat kind support for AF_XDP device plugin #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryamtahhan
commented
Mar 21, 2023
3 tasks
Btw the changes to the makefile allow you to type make help and you will see the following: # make help
Usage:
make <target>
help Display this help.
General Build - assumes K8s environment is already setup
docker Build docker image
podman Build podman image
undeploy Undeploy the Deamonset
deploy Deploy the Deamonset and CNI
General setup
setup-flannel Setup flannel
setup-multus Setup multus
Kind Deployment - sets up a kind cluster and deploys the plugin and CNI
del-kind Remove a kind cluster callled af-xdp-deployment
setup-kind Setup a kind cluster called af-xdp-deployment
label-kind-nodes label the kind worker nodes with cndp="true"
kind-deploy Deploy the Deamonset and CNI in Kind
run-on-kind Setup a kind cluster and deploy the device plugin |
maryamtahhan
commented
Mar 24, 2023
maryamtahhan
force-pushed
the
feat_kind_support
branch
from
March 24, 2023 11:30
e5b7f46
to
b73062e
Compare
Tested with CNDP
|
maryamtahhan
force-pushed
the
feat_kind_support
branch
from
March 24, 2023 14:09
d35fa24
to
8e3eca4
Compare
I'll have a look through the CI and try to fix |
maryamtahhan
commented
May 2, 2023
maryamtahhan
force-pushed
the
feat_kind_support
branch
from
May 3, 2023 11:04
d2c1faa
to
075da67
Compare
maryamtahhan
commented
May 3, 2023
maryamtahhan
commented
May 3, 2023
maryamtahhan
commented
May 3, 2023
maryamtahhan
commented
May 3, 2023
maryamtahhan
commented
May 3, 2023
I will cleanup the suggestions that were put forward by the linter bot... I think that the kind configuration/support as it's used for testing only - should be limited to a single pool. I will also update the code to make this explicit... |
3 tasks
hey @maryamtahhan - is this one still relevant or superseded by "v2" #59 ? |
This is just the kind support... if you review the kind support here alone - the bpf map pinning changes PR will become significantly smaller |
garyloug
previously approved these changes
Jul 14, 2023
Add basic support to deploy in slack. TODO: enable support for virtual interfaces. Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
maryamtahhan
force-pushed
the
feat_kind_support
branch
from
July 17, 2023 14:39
a694675
to
ff6087b
Compare
garyloug
approved these changes
Jul 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #57 in order to build
This PR enables support for deployment of the AF_XDP device plugin in kind. It's been tested with CNDP and updated CNDP to be able to work with the current implementation of the DP.
Note: one limitation for now is that the Pod requires CAP_BPF in the Kind setup. The limitation was due to the
kernel.unprivileged_bpf_disabled
kernel flag being set by default in the kind node. Once this was disabled everything worked as expected.The main value prop here is to enable the spin up of a test environment in a matter of minutes as well as being a building block towards integration with BPFd