This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
get_block_size: if we can't get from ioctl, try from os.stat() #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under some conditions, ioctl FIGETBSZ can't return real value. We can try to use fallback via os.stat() to get block size. Closes intel#15 Signed-off-by: Alexander D. Kanevskiy <kad@kad.name>
Current coverage is 65.39%@@ master #16 diff @@
==========================================
Files 5 5
Lines 988 994 +6
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 648 650 +2
- Misses 340 344 +4
Partials 0 0
|
| return struct.unpack('I', binary_data)[0] | ||
| bsize = struct.unpack('I', binary_data)[0] | ||
| if not bsize: | ||
| import os |
There was a problem hiding this comment.
It would be good to be consistent about where standard modules are imported. I think most of the code imports everything at the beginning, and there may be some exceptions when it comes to some rare/special modules, which are imported inside functions. But stuff like 'os' would always be imported at the beginning. I personally think it is better this way.
But if you prefer "on-demand" import, it is better to change it globablly, rather than doing introducing inconsistent patterns and making the code less clean in general.
There was a problem hiding this comment.
good point. I'll refactor imports in BmapHelpers.py
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some conditions, ioctl FIGETBSZ can't return real value.
We can try to use fallback via os.stat() to get block size.
Closes #15
Signed-off-by: Alexander D. Kanevskiy kad@kad.name