🐎 🎨 [cib/detail] Replace type_pack_element recursive …
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukevalenty
requested changes
May 7, 2022
There was a problem hiding this comment.
thank you for your pull request @krzysztof-jusiak! 😊
i approved your account to execute the github actions. once the unit tests are passing i will be happy to merge this.
krzysztof-jusiak
force-pushed
the
cib/type_pack_element
branch
from
a09f136
to
151e946
Compare
lukevalenty
approved these changes
May 7, 2022
lukevalenty
reviewed
May 7, 2022
Problem: - When `__type_pack_element` builtin is not implemented `type_pack_element` is using recursion which is slow to compile. Solution: - Speed up compilation time by replacing non-recursive version of type_pack_element when `__type_pack_element` is not available by creating inherited list of type and id pairs and leverage inheritance to get the Nth type pack element.
krzysztof-jusiak
force-pushed
the
cib/type_pack_element
branch
from
151e946
to
d416b17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…version
Problem:
__type_pack_elementbuiltin is not implementedtype_pack_elementis using recursion which is slow to compile.
Solution:
__type_pack_elementis not available by creating inherited list of typeand id pairs and leverage inheritance to get the Nth type pack
element.