pkg/topology: perform colonoscopy on testdata. #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we can use fake go.mod files to prevent golang tooling from descending into test data directories that contain files with a ':' in their name, this is not enough. There are other tools, unfortunately hosted on non-unix OSes that do not like ':'s in file names. Cloning the repository fails on these and prevents the hosted tools from working at all. As a workaround, hide offending (test data) files in tarballs and introduce unit test setup and cleanup hooks to extract these tarballs on demand. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
requested review from
kad,
marquiz,
mythi,
askervin,
jukkar and
fmuyassarov
as code owners
jukkar
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we can use fake go.mod files to prevent golang tooling from descending into test data directories that contain files with a ':' in their name, this is not enough. There are other tools, unfortunately hosted on non-unix OSes, that do not like ':'s in file names. Cloning the repository fails on these and prevents the hosted tools from working at all.
As a workaround, hide offending (test data) files in tarballs and introduce unit test setup and cleanup hooks to extract these tarballs on demand.