Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove refs to deprecated io/ioutil #1012

Merged
merged 2 commits into from Aug 11, 2023
Merged

chore: remove refs to deprecated io/ioutil #1012

merged 2 commits into from Aug 11, 2023

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Jul 7, 2023

No description provided.

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@testwill testwill temporarily deployed to dev July 7, 2023 08:43 — with GitHub Actions Inactive
@testwill testwill temporarily deployed to dev July 7, 2023 08:43 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2023

Codecov Report

Merging #1012 (bf836c9) into master (af53ca4) will not change coverage.
The diff coverage is 20.00%.

@@           Coverage Diff           @@
##           master    #1012   +/-   ##
=======================================
  Coverage   31.86%   31.86%           
=======================================
  Files          65       65           
  Lines        9835     9835           
=======================================
  Hits         3134     3134           
  Misses       6411     6411           
  Partials      290      290           
Impacted Files Coverage Δ
pkg/cgroups/cgroupblkio.go 84.51% <0.00%> (ø)
pkg/cgroups/cgroupstats.go 0.00% <0.00%> (ø)
pkg/cri/resource-manager/cache/utils.go 34.69% <0.00%> (ø)
...i/resource-manager/control/page-migrate/demoter.go 17.95% <0.00%> (ø)
...urce-manager/policy/builtin/static-pools/config.go 5.88% <0.00%> (ø)
pkg/cri/resource-manager/cache/cache.go 22.01% <50.00%> (ø)
pkg/blockio/blockio.go 58.98% <100.00%> (ø)
...-manager/policy/builtin/static-pools/stp-policy.go 10.25% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @testwill for the PR.. There still seems to be some occurrences of io/ioutil (git grep ioutil), could you change those as well?

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
LGTM

@testwill testwill temporarily deployed to dev July 17, 2023 10:33 — with GitHub Actions Inactive
@testwill testwill temporarily deployed to dev July 17, 2023 10:33 — with GitHub Actions Inactive
@marquiz
Copy link
Contributor

marquiz commented Aug 11, 2023

ping @klihub

@marquiz marquiz merged commit 2051920 into intel:master Aug 11, 2023
4 checks passed
@testwill testwill deleted the ioutil branch August 11, 2023 14:13
@marquiz marquiz mentioned this pull request Jan 8, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants