Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use golang builtin multierror #1023

Merged
merged 3 commits into from Aug 14, 2023
Merged

Use golang builtin multierror #1023

merged 3 commits into from Aug 14, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Aug 11, 2023

Go v1.20 supports wrapping multiple errors into one.

Depends on #1022

Fix the verify workflow to actually install the specified version of Go.
Previously, because of the yaml parsing peculiarities go v1.2 was
installed.
@marquiz marquiz temporarily deployed to dev August 11, 2023 08:31 — with GitHub Actions Inactive
@marquiz marquiz temporarily deployed to dev August 11, 2023 08:32 — with GitHub Actions Inactive
Go v1.20 supports wrapping multiple errors into one.
@marquiz marquiz temporarily deployed to dev August 11, 2023 09:16 — with GitHub Actions Inactive
@marquiz marquiz temporarily deployed to dev August 11, 2023 09:16 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #1023 (f70c9d4) into master (0baf03f) will not change coverage.
Report is 14 commits behind head on master.
The diff coverage is 87.03%.

@@           Coverage Diff           @@
##           master    #1023   +/-   ##
=======================================
  Coverage   31.86%   31.86%           
=======================================
  Files          65       65           
  Lines        9835     9835           
=======================================
  Hits         3134     3134           
  Misses       6411     6411           
  Partials      290      290           
Files Changed Coverage Δ
...cy/builtin/topology-aware/topology-aware-policy.go 16.17% <0.00%> (ø)
pkg/blockio/blockio.go 58.98% <83.33%> (ø)
pkg/cgroups/cgroupblkio.go 84.51% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

klihub
klihub previously approved these changes Aug 11, 2023
Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub klihub temporarily deployed to dev August 14, 2023 07:49 — with GitHub Actions Inactive
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub klihub merged commit 53b476d into intel:master Aug 14, 2023
4 checks passed
@marquiz marquiz deleted the devel/multierror branch August 14, 2023 08:09
@marquiz marquiz mentioned this pull request Jan 8, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants