New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: split security scanning into re-usable jobs #1033
github: split security scanning into re-usable jobs #1033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7dd18a4
to
41ebca0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Hoping that we'll see logs soon...
Split the security scanning workflow into separate parameterized jobs. This makes them re-usable for diiferent workflows, e.g. CI on PRs and image-publishing. Also drop unneeded and broken parts from the CodeQL scanning job.
41ebca0
to
40b9761
Compare
Codecov Report
@@ Coverage Diff @@
## master #1033 +/- ##
=======================================
Coverage 31.73% 31.73%
=======================================
Files 64 64
Lines 9816 9816
=======================================
Hits 3115 3115
Misses 6410 6410
Partials 291 291 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Split the security scanning workflow into separate parameterized jobs. This makes them re-usable for diiferent workflows, e.g. CI on PRs and image-publishing.
Also drop unneeded and broken parts from the CodeQL scanning job.