Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: split security scanning into re-usable jobs #1033

Merged
merged 1 commit into from Aug 15, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Aug 14, 2023

Split the security scanning workflow into separate parameterized jobs. This makes them re-usable for diiferent workflows, e.g. CI on PRs and image-publishing.

Also drop unneeded and broken parts from the CodeQL scanning job.

klihub
klihub previously approved these changes Aug 14, 2023
Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

askervin
askervin previously approved these changes Aug 14, 2023
Copy link
Contributor

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Hoping that we'll see logs soon...

Split the security scanning workflow into separate parameterized jobs.
This makes them re-usable for diiferent workflows, e.g. CI on PRs and
image-publishing.

Also drop unneeded and broken parts from the CodeQL scanning job.
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #1033 (40b9761) into master (639e2d7) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1033   +/-   ##
=======================================
  Coverage   31.73%   31.73%           
=======================================
  Files          64       64           
  Lines        9816     9816           
=======================================
  Hits         3115     3115           
  Misses       6410     6410           
  Partials      291      291           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@klihub klihub requested a review from askervin August 15, 2023 13:37
Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@klihub klihub merged commit 9b471ce into intel:master Aug 15, 2023
5 checks passed
@marquiz marquiz deleted the devel/ci-refactor-security-scanning branch August 15, 2023 18:02
@marquiz marquiz mentioned this pull request Jan 8, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants