e2e: fix topology-aware/n4c16/test09-container-exit test #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"sleep" in the latest busybox does not create a child process named "sleep". Change process matching from sleep to matching pod0c0 parent/child instead.
askervin
requested review from
kad,
klihub,
marquiz,
mythi and
fmuyassarov
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1050 +/- ##
=======================================
Coverage 31.73% 31.73%
=======================================
Files 64 64
Lines 9816 9816
=======================================
Hits 3115 3115
Misses 6410 6410
Partials 291 291 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
klihub
reviewed
Aug 21, 2023
| @@ -8,7 +8,13 @@ pyexec 'assert "pod0c0" in allocations' | |||
|
|
|||
| out '### Crash and restart pod0c0' | |||
| vm-command "kubectl get pods pod0" | |||
| vm-command "kill -KILL \$(pgrep -f pod0c0)" | |||
|
|
|||
| vm-command "set -x; [[ -n \"\$(pgrep -f pod0c0)\" ]] && [[ \"\$(pgrep -f pod0c0 --oldest)\" != \"\$(pgrep -f pod0c0 --newest)\" ]]" || { | |||
There was a problem hiding this comment.
Is that set -x needed/wanted or just a debugging leftover ?
There was a problem hiding this comment.
set -x is there by purpose. Similarly to "kubectl get pods pod0" above, it is not strictly necessary but helps figuring out pids in the system from the test output, should the test fail again in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"sleep" in the latest busybox does not create a child process named "sleep". Change process matching from sleep to matching pod0c0 parent/child instead.