e2e: relax dynamic demotion first detection round requirement #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askervin
requested review from
kad,
klihub,
marquiz,
mythi and
fmuyassarov
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1053 +/- ##
=======================================
Coverage 31.73% 31.73%
=======================================
Files 64 64
Lines 9816 9816
=======================================
Hits 3115 3115
Misses 6410 6410
Partials 291 291 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marquiz
reviewed
Aug 22, 2023
| @@ -36,7 +36,7 @@ pages_per_second_per_process="$(awk ' | |||
|
|
|||
| # After how many rounds (seconds) first migrations should be visible. | |||
| first_migrations_visible="$(awk ' | |||
| /PageScanInterval:/{gsub(/[^0-9]/, "", $2); print $2+3} | |||
| /PageScanInterval:/{gsub(/[^0-9]/, "", $2); print $2+5} | |||
There was a problem hiding this comment.
I suggest to make this 10, in my testing 5 (round 15) was on the limit
Suggested change
| /PageScanInterval:/{gsub(/[^0-9]/, "", $2); print $2+5} | |
| /PageScanInterval:/{gsub(/[^0-9]/, "", $2); print $2+10} |
There was a problem hiding this comment.
Or at least +6 to have some margin for "fluctiations"
There was a problem hiding this comment.
I agree. Let's increase the margin still.
Strict requirement makes the test flaky. Give two more rounds time for detecting first memory moves.
askervin
force-pushed
the
5QV_e2e_relax_dynamic_demotion
branch
from
9f9cd7d
to
6699d6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strict requirement makes the test flaky. Give two more rounds time for detecting first memory moves.