e2e: use bridge cni plugin by default #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bridge networking is stupid and simple and works perfectly in our one node cluster setup. More complicated CNI setup brings no value in terms of testing cri-resmgr. Using bridge speeds up tests considerably (by eliminating all clilium/weavenet download and initialization time) plus should virtually eliminate all test flakyness related to CNI plugin failures.
marquiz
requested review from
kad,
klihub,
mythi,
askervin and
fmuyassarov
as code owners
klihub
approved these changes
Aug 23, 2023
askervin
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bridge networking is stupid and simple and works perfectly in our one node cluster setup. More complicated CNI setup brings no value in terms of testing cri-resmgr. Using bridge speeds up tests considerably (by eliminating all clilium/weavenet download and initialization time) plus should virtually eliminate all test flakyness related to CNI plugin failures.