e2e: add --wait to kubectl delete of pods and namespaces #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marquiz
requested review from
kad,
klihub,
mythi,
askervin and
fmuyassarov
as code owners
klihub
previously approved these changes
Aug 23, 2023
marquiz
force-pushed
the
devel/e2e-wait
branch
from
0550e87
to
d598707
Compare
|
I simplified this a bit, not adding |
Add --wait and --ignore-missing (to make sure that we really wait for the objects that does exist) to prevent naming collisions caused by long termination times of pods. Also add --now where it is missing so that stuff gets deleted quickly.
marquiz
force-pushed
the
devel/e2e-wait
branch
from
d598707
to
ef40cce
Compare
klihub
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --wait and --ignore-missing (to make sure that we really wait for the objects that does exist) to prevent naming collisions caused by long termination times of pods. Also add --now where it is missing so that stuff gets deleted quickly.