e2e: support for verify --retry N #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askervin
requested review from
kad,
klihub,
marquiz,
mythi and
fmuyassarov
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1069 +/- ##
=======================================
Coverage 31.73% 31.73%
=======================================
Files 64 64
Lines 9816 9816
=======================================
Hits 3115 3115
Misses 6410 6410
Partials 291 291 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Aug 25, 2023
marquiz
reviewed
Aug 25, 2023
test/e2e/run.sh
Outdated
| @@ -765,6 +770,30 @@ verify() { # script API | |||
| # nodes and that pod0c0 is allowed to run on 4 CPUs: | |||
| # verify 'set.intersection(nodes["pod0c0"], nodes["pod1c0"]) == set()' \ | |||
| # 'len(cpus["pod0c0"]) == 4' | |||
| local retries=0 | |||
There was a problem hiding this comment.
We need to have default re-try count in order to fight flakyness
Suggested change
| local retries=0 | |
| local retries=3 |
klihub
previously approved these changes
Aug 25, 2023
askervin
force-pushed
the
5QX_e2e_verify_retry
branch
from
ae8d3d2
to
52443b6
Compare
marquiz
force-pushed
the
5QX_e2e_verify_retry
branch
from
52443b6
to
586fcff
Compare
marquiz
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.