Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/cri: implement container event relaying. #1085

Merged
merged 1 commit into from Jan 11, 2024

Conversation

klihub
Copy link
Contributor

@klihub klihub commented Jan 9, 2024

This PR implements relaying the stream of events for CRI streaming GetContainerEvents() calls.

Implement relaying the stream of events for CRI streaming
GetContainerEvents() calls.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Copy link
Contributor

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raising one concern that might be just because of not understanding the big picture...

pkg/cri/relay/runtime-service.go Show resolved Hide resolved
Copy link
Contributor

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marquiz marquiz merged commit 9ddf702 into intel:master Jan 11, 2024
10 checks passed
@marquiz marquiz mentioned this pull request Jan 11, 2024
18 tasks
@klihub klihub deleted the fixes/relay-container-events branch January 11, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants