e2e: Do not try to use govm if user has specified the VM address #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user has specified VM_IP when starting run.sh, then there is no need to try to resolve the IP address of the VM. This allows the script to be used to configure non govm based hosts.
jukkar
requested review from
ipuustin,
kad,
klihub,
marquiz and
mythi
as code owners
Codecov Report
@@ Coverage Diff @@
## master #738 +/- ##
=======================================
Coverage 36.99% 36.99%
=======================================
Files 54 54
Lines 8021 8021
=======================================
Hits 2967 2967
Misses 4776 4776
Partials 278 278 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user has specified VM_IP when starting run.sh, then there is
no need to try to resolve the IP address of the VM. This allows
the script to be used to configure non govm based hosts.