Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct one typo and two nitpicks. #740

Merged
merged 1 commit into from Nov 24, 2021
Merged

Conversation

huangrui666
Copy link
Contributor

Modify policys-specific to policy-specific.
Improve the parsing process on /proc/cpu.

Signed-off-by: Huang Rui rui1.huang@intel.com

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #740 (f17bfb4) into master (62fd9ef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #740   +/-   ##
=======================================
  Coverage   36.99%   36.99%           
=======================================
  Files          54       54           
  Lines        8021     8021           
=======================================
  Hits         2967     2967           
  Misses       4776     4776           
  Partials      278      278           
Impacted Files Coverage Δ
...esource-manager/policy/builtin/podpools/metrics.go 0.00% <ø> (ø)
...-manager/policy/builtin/static-pools/stp-policy.go 10.25% <ø> (ø)
...cy/builtin/topology-aware/topology-aware-policy.go 16.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62fd9ef...f17bfb4. Read the comment docs.

Copy link
Contributor

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested with the tests in the draft PR, works fine.
Thanks Rui!

Modify policys-specific to policy-specific.
Improve the parsing process on /proc/cpu.

Signed-off-by: Huang Rui <rui1.huang@intel.com>
Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub klihub merged commit ed165ca into intel:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants