e2e: support k8scni=<cilium|weavenet|flannel> #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askervin
requested review from
ipuustin,
kad,
klihub,
marquiz and
mythi
as code owners
Codecov Report
@@ Coverage Diff @@
## master #747 +/- ##
=======================================
Coverage 37.16% 37.16%
=======================================
Files 54 54
Lines 8035 8035
=======================================
Hits 2986 2986
Misses 4761 4761
Partials 288 288 Continue to review full report at Codecov.
|
klihub
reviewed
Jan 3, 2022
Comment on lines
+949
to
+951
| echo 10.244.0.0/16 | ||
| else | ||
| echo 10.217.0.0/16 |
There was a problem hiding this comment.
Is this special-case required by flannel ?
klihub
reviewed
Jan 3, 2022
klihub
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to the
k8scriparameter, allow user to define which CNI to install on new cluster by settingk8scni.This patch also adds support to the flannel CNI.
Setting
reinstall_bootstrapis added to keep our shellcheck (git hook) happy.