Statically linked binaries in container images #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use statically linked binaries in the agent and webhook container images. We now have scratch-based images than only contain one file (which is the agent or webhook binary) - clean and simple. With this we also ditch the cumbersome clearlinux based build which does not even support go v1.17 (or later).
marquiz
requested review from
kad,
klihub,
ipuustin,
mythi,
askervin and
jukkar
as code owners
Codecov Report
@@ Coverage Diff @@
## master #793 +/- ##
=======================================
Coverage 37.53% 37.53%
=======================================
Files 55 55
Lines 8125 8125
=======================================
Hits 3050 3050
Misses 4780 4780
Partials 295 295 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
jukkar
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use statically linked binaries in the agent and webhook container
images. We now have scratch-based images than only contain one file
(which is the agent or webhook binary) - clean and simple. With this we
also ditch the cumbersome clearlinux based build which does not even
support go v1.17 (or later).