Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SST discovery #803

Merged
merged 2 commits into from Apr 8, 2022
Merged

Fix SST discovery #803

merged 2 commits into from Apr 8, 2022

Conversation

jukkar
Copy link
Contributor

@jukkar jukkar commented Apr 8, 2022

This fixes compilation error because goresctrl SST discovery API was changed and now we are using the latest version.

@jukkar
sst: Update the code because of goresctrl changes
faa5d25 
SstPackageInfo struct was changed in goresctrl library so fix
the cri-rm code to reflect this.
marquiz
marquiz requested changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run go mod tidy after updating go.mod

@jukkar
Copy link
Contributor Author

jukkar commented Apr 8, 2022

Please run go mod tidy after updating go.mod

done

marquiz
marquiz approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jukkar 👍 It was about time to update goresctrl...
lgtm

klihub
klihub approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@klihub klihub merged commit 117f72b into intel:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klihub klihub klihub approved these changes

@marquiz marquiz marquiz approved these changes

@kad kad Awaiting requested review from kad kad is a code owner

@ipuustin ipuustin Awaiting requested review from ipuustin

@mythi mythi Awaiting requested review from mythi mythi is a code owner

@askervin askervin Awaiting requested review from askervin askervin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jukkar @klihub @marquiz