New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resmgr: disallow talking to untested runtimes by default. #821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh 👌
/lgtm
A bit mixed feelings about this... a warning would have been easier for me, but at the same time I know that nobody would notice the warning, except for us when we are after a ghost already. And on the other hand the scenario where we should to take back this change and allow docker by default, seems to be highly unlikely, says the crystal ball. As a downside, we will need to add a couple of sentences about docker in our documentation, yet getting rid of it completely would be even nicer. So after all, I suppose this is ok. |
bc172a1
to
a5c68a5
Compare
There are mainly two reasons I chose to go with this approach:
I think we should remove all documentation reference to docker. And add a single paragraph stating that:
I added a mention of the necessary command line option to the rejection error message. |
e39a07d
to
28a38c3
Compare
I wiped out all existing instructions related to |
28a38c3
to
0360534
Compare
0360534
to
aa7fa29
Compare
Refuse to talk to untested runtimes unless explicitly told to do so using the --allow-untested-runtimes command line option.
aa7fa29
to
bc17218
Compare
Disallow talking to/proxying for unknown runtimes, unless explicitly told to do so on the command line. This could save us quite a bit of time from chasing ghosts.
Inspired by an idea from @jukkar over a lunch discussion. Thanks !