e2e: add test for dynamic balloons configuration update #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs balloons configuration update patch from PR #830. |
askervin
force-pushed
the
5JD_e2e_balloons_config_update
branch
from
0d5740e
to
4588475
Compare
askervin
requested review from
kad,
klihub,
marquiz,
ipuustin,
mythi and
jukkar
as code owners
klihub
requested changes
Jun 17, 2022
Comment on lines
6
to
21
| cleanup() { | ||
| kubectl delete pods --all --now | ||
| ( kubectl delete namespace $testns ) | ||
| ( kubectl delete btype1ns0 ) | ||
| terminate cri-resmgr | ||
| terminate cri-resmgr-agent | ||
| vm-command "cri-resmgr -reset-policy; cri-resmgr -reset-config" | ||
| } | ||
|
|
||
| apply-configmap() { | ||
| vm-put-file $(instantiate balloons-configmap.yaml) balloons-configmap.yaml | ||
| vm-command "cat balloons-configmap.yaml" | ||
| kubectl apply -f balloons-configmap.yaml | ||
| } |
There was a problem hiding this comment.
Hmm... shouldn't it be something like:
cleanup() {
vm-command "kubectl delete pods --all --now; \
kubectl delete pods -n $testns --all --now; \
kubectl delete pods -n btype1ns0 --all --now; \
kubectl delete namespace $testns || :; \
kubectl delete namespace btype1ns0 || :"
terminate cri-resmgr
terminate cri-resmgr-agent
vm-command "cri-resmgr -reset-policy; cri-resmgr -reset-config"
}
apply-configmap() {
vm-put-file $(instantiate balloons-configmap.yaml) balloons-configmap.yaml
vm-command "cat balloons-configmap.yaml"
vm-command "kubectl apply -f balloons-configmap.yaml"
}
klihub
reviewed
Jun 17, 2022
| BTYPE0_CPUCLASS="classC" BTYPE1_SKIP=1 BTYPE2_CPUCLASS="classB" BTYPE2_NAMESPACE0='"*"' apply-configmap | ||
| verify-metrics-has-line 'btype0\[0\].*pod0:pod0c0.*cpu_class="classC"' | ||
| verify-metrics-has-line 'btype2\[0\].*pod1:pod1c0.*cpu_class="classB"' | ||
| verify-metrics-has-line 'btype2\[0\].*pod2:pod2c0.*cpu_class="classB"' |
There was a problem hiding this comment.
And do a final
cleanup
here at the end too, please.
- Add new test that changes balloons and CPU configurations using a config map. - Refactor verify-metrics functions to a common source file.
askervin
force-pushed
the
5JD_e2e_balloons_config_update
branch
from
4588475
to
85abe96
Compare
klihub
reviewed
Jun 17, 2022
test/e2e/policies.test-suite/balloons/n4c16/test06-update-configmap/code.var.sh
Show resolved
Hide resolved
klihub
reviewed
Jun 17, 2022
test/e2e/policies.test-suite/balloons/n4c16/test06-update-configmap/code.var.sh
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config map.