fixes: substitute golang version from go.mod. #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
requested review from
kad,
marquiz,
ipuustin,
mythi,
askervin and
jukkar
as code owners
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
=======================================
Coverage 37.53% 37.53%
=======================================
Files 56 56
Lines 8179 8179
=======================================
Hits 3070 3070
Misses 4811 4811
Partials 298 298 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
klihub
force-pushed
the
fixes/substitute-golang-version
branch
3 times, most recently
from
5a38af4
to
3ec2e00
Compare
klihub
force-pushed
the
fixes/substitute-golang-version
branch
from
3ec2e00
to
864bbb9
Compare
marquiz
approved these changes
Jun 17, 2022
| RUN apt-get update && apt-get install -y git | ||
| RUN apt-get update && apt-get install -y wget git | ||
|
|
||
| # Note: Any golang version that can 'go list -m -f {{.Variable}}' is fine... |
There was a problem hiding this comment.
Yeah, good comment. I think this is good here, we shouldn't get any breakages in the foreseeable future because of this. We could of course have ARG GOLANG_VERSION=x.yz here, too, but might be just unnecessary complication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.