test/e2e: don't use invalid '0' CPU reservation. #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
requested review from
kad,
marquiz,
ipuustin,
mythi,
askervin and
jukkar
as code owners
Codecov Report
@@ Coverage Diff @@
## master #840 +/- ##
=======================================
Coverage 37.53% 37.53%
=======================================
Files 56 56
Lines 8179 8179
=======================================
Hits 3070 3070
Misses 4811 4811
Partials 298 298 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
klihub
force-pushed
the
fixes/colocation-test-config
branch
2 times, most recently
from
6205bd5
to
42ffb7e
Compare
Don't use invalid 'cpu: 0' CPU reservation (the correct syntax for picking an exact CPU would be 'cpu: cpuset:0). Use the same 'CPU: 750m' as we use in the default config.
klihub
force-pushed
the
fixes/colocation-test-config
branch
from
42ffb7e
to
352dfab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use invalid 'cpu: 0' CPU reservation. Don't even use a test-specific configuration file.
Instead, parameterize the top-level one correctly for the test case.