[release 0.7] backport image building fixes #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use scratch as the base image now so now dynamically loaded libs are available. (cherry picked from commit 04454e1)
This fixes build of agent and webhook images. Otherwise they will fail because go-build is not able to find the vcs information. Could be handled with '-buildvcs=false' build flag but just removing chdir seems simpler. Plus, we get the vcs information in the go binary. (cherry picked from commit 82acdf6)
marquiz
requested review from
kad,
klihub,
ipuustin,
mythi,
askervin and
jukkar
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use scratch as the base image now so now dynamically loaded libs are
available.
This fixes build of agent and webhook images. Otherwise they will fail
because go-build is not able to find the vcs information. Could be
handled with '-buildvcs=false' build flag but just removing chdir seems
simpler. Plus, we get the vcs information in the go binary.