e2e: check if cri-resmgr is expected to run with different policy #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askervin
requested review from
kad,
klihub,
marquiz,
ipuustin,
mythi and
jukkar
as code owners
Codecov Report
@@ Coverage Diff @@
## master #890 +/- ##
=======================================
Coverage 34.89% 34.89%
=======================================
Files 60 60
Lines 8869 8869
=======================================
Hits 3095 3095
Misses 5472 5472
Partials 302 302 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
klihub
reviewed
Sep 8, 2022
jukkar
previously approved these changes
Sep 8, 2022
klihub
previously approved these changes
Sep 8, 2022
E2E tests generally avoid restarting cri-resmgr for faster execution. This causes false FAILs when the same vm runs one test from policy A followed by another test from policy B without forced cri-resmgr restarting. This patch adds a script that run_tests.sh imports automatically when running any test from the policies test suite. The script checks if vm is running cri-resmgr with different policy than what next test expects, and if so, restarts cri-resmgr with cache cleared when needed.
askervin
force-pushed
the
5Kh_e2e_reset_if_policy_changed
branch
from
d6c6d54
to
5ca93ae
Compare
jukkar
reviewed
Sep 8, 2022
jukkar
approved these changes
Sep 8, 2022
klihub
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E2E tests generally avoid restarting cri-resmgr for faster execution. This causes false FAILs when the same vm runs one test from policy A followed by another test from policy B without forced cri-resmgr restarting. This patch adds a script that run_tests.sh imports automatically when running any test from the policies test suite. The script checks if vm is running cri-resmgr with different policy than what next test expects, and if so, restarts cri-resmgr with cache cleared when needed.