balloons: fix empty cpuset of a balloon that has containers #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askervin
requested review from
kad,
klihub,
marquiz,
mythi and
jukkar
as code owners
Keep at least 1 CPU in every balloon that has containers, even if the sum of requested CPUs of the containers would be 0. Otherwise we would allow cpuset of a balloon to become empty, and thus the CPUs of those containers would not be pinned anymore.
askervin
force-pushed
the
5LT_no_empty_balloons_with_containers
branch
from
72e36f2
to
e7a5f2a
Compare
jukkar
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep at least 1 CPU in every balloon that has containers, even if the sum of requested CPUs of the containers would be 0. Otherwise we would allow cpuset of a balloon to become empty, and thus the CPUs of those containers would not be pinned anymore.