Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forwardport: Update outdated dependencies #918

Merged
merged 1 commit into from Nov 17, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Nov 15, 2022

(cherry picked from commit fe6ce42)

Just happened to notice that master had outdated deps which were fixed in the release branch. We should really try to avoid fixing things in release branches. Only accept backports

(cherry picked from commit fe6ce42)
@codecov-commenter
Copy link

Codecov Report

Merging #918 (5baa85c) into master (2ce10b0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #918   +/-   ##
=======================================
  Coverage   34.90%   34.90%           
=======================================
  Files          60       60           
  Lines        8868     8868           
=======================================
  Hits         3095     3095           
  Misses       5471     5471           
  Partials      302      302           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marquiz
Copy link
Contributor Author

marquiz commented Nov 17, 2022

ping @klihub @askervin @fmuyassarov I'd be happier if somebody else than memyself merged this 😊

Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I don't have rights to merge unfortunately.

@klihub klihub merged commit 66d60c8 into intel:master Nov 17, 2022
@marquiz marquiz deleted the devel/forwardports branch November 23, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants