Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rebased #778] scripts: pairwise maximizes covered triplets #929

Merged
merged 1 commit into from Nov 23, 2022

Conversation

klihub
Copy link
Contributor

@klihub klihub commented Nov 23, 2022

This PR is #778 rebased on the latest master.

  • Taking triplet coverage into account improves data coverage without increasing the number of parameter sets.
  • As a downside, this implementation is naive and may cause performance problems with large data sets.

- Taking triplet coverage into account improves data coverage without
  increasing the number of parameter sets.
- As a downside, this implementation is naive and may cause
  performance problems with large data sets.
Copy link
Contributor

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klihub , thanks for rebasing and creating new PR on this!

LGTM.

@codecov-commenter
Copy link

Codecov Report

Merging #929 (08b7b8e) into master (45a4b99) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #929   +/-   ##
=======================================
  Coverage   34.87%   34.87%           
=======================================
  Files          60       60           
  Lines        8874     8874           
=======================================
  Hits         3095     3095           
  Misses       5477     5477           
  Partials      302      302           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marquiz marquiz merged commit d88a688 into intel:master Nov 23, 2022
@klihub klihub deleted the askervin-rebased-PR-778 branch November 23, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants