test/e2e: update packaging tests #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marquiz
requested review from
kad,
klihub,
mythi,
askervin,
jukkar and
fmuyassarov
as code owners
marquiz
force-pushed
the
devel/e2e-packaging
branch
from
320ce49
to
7fc6ac6
Compare
jukkar
reviewed
Dec 12, 2022
klihub
reviewed
Dec 12, 2022
There was a problem hiding this comment.
I'm fine with the changes and they make sense, but I think @jukkar is right that it would be nice to get something like these in the commit messages
- use 15.4 instead of 15.2 for OpenSUSE packaging tests
- drop EOL'd Ubuntu 21.04 from packaging tests
askervin
previously approved these changes
Dec 13, 2022
There was a problem hiding this comment.
LGTM.
demo/lib/distro.bash does not have support for opensuse-15.4 yet, though. As a result, this packaging test will currently run on opensuse-15.3.
I tried out adding it:
opensuse-image-url() {
opensuse-15_4-image-url
}
opensuse-15_4-image-url() {
echo "https://download.opensuse.org/pub/opensuse/distribution/leap/15.4/appliances/openSUSE-Leap-15.4-JeOS.x86_64-15.4-OpenStack-Cloud-Current.qcow2"
}
However, Qemu seems to be stuck in boot-loop. This can be addressed in later commits, anyway.
marquiz
force-pushed
the
devel/e2e-packaging
branch
from
7fc6ac6
to
99042f0
Compare
Added reasoning to the commit messages |
jukkar
previously approved these changes
Dec 13, 2022
marquiz
force-pushed
the
devel/e2e-packaging
branch
from
99042f0
to
f91d6b8
Compare
Ubuntu 21.04 is EOL'd a long time ago and we don't build packages for it so let's drop it from packaging tests as well.
Change openSUSE packaging tests from Leap 15.2 to 15.4 as that's the version that we currently build packages for.
klihub
force-pushed
the
devel/e2e-packaging
branch
from
f91d6b8
to
02fb8a5
Compare
jukkar
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.