Makefile: user gomodcache from host in cross-builds #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marquiz
requested review from
kad,
klihub,
mythi,
askervin,
jukkar and
fmuyassarov
as code owners
Codecov Report
@@ Coverage Diff @@
## master #957 +/- ##
=======================================
Coverage 34.06% 34.06%
=======================================
Files 61 61
Lines 9054 9054
=======================================
Hits 3084 3084
Misses 5687 5687
Partials 283 283 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
klihub
reviewed
Dec 13, 2022
Makefile
Outdated
| echo "Docker cross-building $$distro packages..."; \ | ||
| mkdir -p $(PACKAGES_DIR)/$$distro && \ | ||
| rm -fr $$builddir && mkdir -p $$builddir/{input,build} && \ | ||
| cp cri-resource-manager-$(TAR_VERSION).tar$(GZEXT) $$builddir/input && \ | ||
| cp packaging/rpm/cri-resource-manager.spec $$builddir/input && \ | ||
| $(DOCKER) run --rm -ti $(DOCKER_OPTIONS) --user $(shell echo $$USER) \ | ||
| $(DOCKER) run --rm -ti $(DOCKER_OPTIONS) --user $$user \ |
There was a problem hiding this comment.
Out of curiosity: is setting $user then dereferencing it vs. using $USER a workaround/fix for running in non-login shells ? IOW, what does it fix ?
There was a problem hiding this comment.
Doesn't actually fix anything, although I thought it might be more reliable than relying on env variables. Maybe $USER would be enough
There was a problem hiding this comment.
Changed it to $USER to keep the changes minimal (and simplify a bit)
klihub
reviewed
Dec 13, 2022
Speeds up the builds dramatically by eliminating a lot of go mod download time.
marquiz
force-pushed
the
devel/cross-build-cache
branch
from
babd5d8
to
6a27748
Compare
askervin
approved these changes
Dec 14, 2022
jukkar
reviewed
Dec 14, 2022
jukkar
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up the builds dramatically by eliminating a lot of go mod download time.