cgroups: fix controller filesystem path in cgroup v2 #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
askervin
commented
Dec 15, 2022
askervin
commented
- Fixes page demotion in cgroup v2. This was failing because GetProcesses() and GetCgroupDir() did not work.
askervin
requested review from
kad,
klihub,
marquiz,
mythi,
jukkar and
fmuyassarov
as code owners
askervin
force-pushed
the
5ML_fix_cgroupv2_path
branch
from
bb6e162
to
0656dab
Compare
Codecov Report
@@ Coverage Diff @@
## master #961 +/- ##
==========================================
- Coverage 33.74% 33.68% -0.06%
==========================================
Files 61 61
Lines 9140 9156 +16
==========================================
Hits 3084 3084
- Misses 5773 5789 +16
Partials 283 283
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
- Fixes page demotion in cgroup v2. This was failing because GetProcesses() and GetCgroupDir() did not work.
marquiz
force-pushed
the
5ML_fix_cgroupv2_path
branch
from
0656dab
to
ccc43c2
Compare
marquiz
reviewed
Dec 19, 2022
| @@ -83,3 +88,14 @@ func init() { | |||
| flag.StringVar(&KubeletRoot, "kubelet-cgroup-root", KubeletRoot, | |||
| "--cgroup-root options the kubelet is running with") | |||
| } | |||
|
|
|||
| func DetectSystemCgroupVersion() int { | |||
There was a problem hiding this comment.
I'd suggest to do smth like this instead, possibly import/copy it directly
https://github.com/containerd/cgroups/blob/e8802a182774b8e25cc65b5c374389338cc8e6c3/utils.go#L53
marquiz
reviewed
Dec 19, 2022
marquiz
reviewed
Dec 19, 2022
marquiz
approved these changes
Dec 19, 2022
jukkar
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.