podpools: fix synchronizing all running containers at start #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askervin
requested review from
kad,
klihub,
marquiz,
mythi,
jukkar and
fmuyassarov
as code owners
Codecov Report
@@ Coverage Diff @@
## master #965 +/- ##
=======================================
Coverage 33.68% 33.68%
=======================================
Files 61 61
Lines 9156 9156
=======================================
Hits 3084 3084
Misses 5789 5789
Partials 283 283
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jukkar
previously approved these changes
Dec 20, 2022
klihub
reviewed
Dec 20, 2022
pkg/cri/resource-manager/policy/builtin/podpools/podpools-policy.go
Outdated
Show resolved
Hide resolved
This change makes podpools start similar to the balloons policy start: find all running containers in the system.
askervin
force-pushed
the
5MQ_podpools_fix_start_sync
branch
from
fd68471
to
90b28a5
Compare
klihub
approved these changes
Dec 20, 2022
jukkar
approved these changes
Dec 21, 2022
marquiz
reviewed
Dec 21, 2022
| verify-log-vs-metrics pod5:pod5c1 0 20 | ||
| # There should be kube-apiserver, etcd etc. running on reserved CPUs as well, | ||
| # therefore allow a lot of CPU usage yet pod5 is not doing anything. | ||
| verify-log-vs-metrics pod5:pod5c1 0 100 |
There was a problem hiding this comment.
Yes, strongly. Now that the fix in policy Start() makes sure that kube-apiserver and etcd (among others) will be pinned to the reserved CPU - the same CPU where pod5 is scheduled too - the CPU load of that CPU can be much higher than at the time when this test was written. I got one failed test run because of that: the two processes may easily cause > 20% load on the only reserved CPU in our e2e VMs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes podpools start similar to the balloons policy start: find all running containers in the system.