metrics: fix collecting hugetlb statistics from cgroup v1 #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
askervin
commented
Dec 23, 2022
askervin
commented
- Hugetlb statistics collector matched both usage and (later added) reservation accounting files (.rsvd.). When both were present, the collector tried to create duplicate metrics entries: usage and reservation values got the same name and labels.
- This patch ignores .rsvd. files when collecting statistics in order to keep reporting exactly what was reported before them.
- Fixes error "cgroup_hugetlb_usage... collected before with the same name and label values" error in cri-resmgr output.
- Fixes issue curl metrics issue #859.
- Hugetlb statistics collector matched both usage and (later added) reservation accounting files (*.rsvd.*). When both were present, the collector tried to create duplicate metrics entries: usage and reservation values got the same name and labels. - This patch ignores *.rsvd.* files when collecting statistics in order to keep reporting exactly what was reported before them. - Fixes error "cgroup_hugetlb_usage... collected before with the same name and label values" error in cri-resmgr output. - Fixes issue intel#859.
askervin
requested review from
kad,
klihub,
marquiz,
mythi,
jukkar and
fmuyassarov
as code owners
Codecov Report
@@ Coverage Diff @@
## master #968 +/- ##
==========================================
- Coverage 33.68% 33.67% -0.01%
==========================================
Files 61 61
Lines 9156 9158 +2
==========================================
Hits 3084 3084
- Misses 5789 5791 +2
Partials 283 283
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jukkar
approved these changes
Dec 23, 2022
marquiz
approved these changes
Dec 23, 2022
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.