Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdt: stop trying to get container cgroup dir #975

Merged
merged 1 commit into from Feb 17, 2023
Merged

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Feb 17, 2023

We don't use that information for anything. In an error case we'll get the same error from container.GetProcesses() later anyway.

We don't use that information for anything. In an error case we'll get
the same error from container.GetProcesses() later anyway.
Copy link
Member

@kad kad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

Codecov Report

Merging #975 (61acbd7) into master (4674927) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #975   +/-   ##
=======================================
  Coverage   31.96%   31.96%           
=======================================
  Files          65       65           
  Lines        9833     9833           
=======================================
  Hits         3143     3143           
  Misses       6402     6402           
  Partials      288      288           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marquiz
Copy link
Contributor Author

marquiz commented Feb 17, 2023

ping @jukkar

@jukkar jukkar merged commit 7e30e27 into intel:master Feb 17, 2023
@marquiz marquiz deleted the devel/rdt branch February 22, 2023 08:58
@klihub klihub mentioned this pull request Apr 19, 2023
25 tasks
@marquiz marquiz mentioned this pull request Jan 8, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants