Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump builds to use Golang v1.20.2 #982

Merged
merged 1 commit into from Apr 4, 2023
Merged

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Feb 21, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #982 (f1a44f2) into master (7fb2d34) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   31.95%   31.86%   -0.10%     
==========================================
  Files          65       65              
  Lines        9835     9835              
==========================================
- Hits         3143     3134       -9     
- Misses       6404     6411       +7     
- Partials      288      290       +2     
Impacted Files Coverage Δ
pkg/cgroups/cgroupblkio.go 84.51% <ø> (ø)
pkg/cpuallocator/allocator.go 48.32% <ø> (ø)
pkg/log/log.go 19.00% <0.00%> (ø)
...rce-manager/policy/builtin/topology-aware/pools.go 61.73% <0.00%> (-1.74%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

klihub
klihub previously approved these changes Feb 21, 2023
fmuyassarov
fmuyassarov previously approved these changes Feb 21, 2023
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marquiz
Copy link
Contributor Author

marquiz commented Feb 21, 2023

Pick either this or #981 😉

jukkar
jukkar previously approved these changes Feb 22, 2023
Copy link
Contributor

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with both versions.

@klihub klihub marked this pull request as draft February 22, 2023 08:42
@klihub
Copy link
Contributor

klihub commented Feb 22, 2023

Marked as draft. Let's keep this ready in the back pocket until we're more confident to switch to 1.20.

@marquiz marquiz closed this Feb 22, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Feb 22, 2023

We chose #981

@marquiz
Copy link
Contributor Author

marquiz commented Feb 22, 2023

Rebased

Bump from v1.19 to the latest patch release of v1.20.
@marquiz marquiz changed the title Bump builds to use Golang v1.20.1 Bump builds to use Golang v1.20.2 Apr 4, 2023
@marquiz marquiz marked this pull request as ready for review April 4, 2023 08:26
@marquiz marquiz temporarily deployed to dev April 4, 2023 08:27 — with GitHub Actions Inactive
@marquiz marquiz temporarily deployed to dev April 4, 2023 08:27 — with GitHub Actions Inactive
@marquiz
Copy link
Contributor Author

marquiz commented Apr 4, 2023

Updated to v1.20.2. Moved out of dfaft state. Ping @klihub

@klihub klihub merged commit bf56d5f into intel:master Apr 4, 2023
4 checks passed
@marquiz marquiz mentioned this pull request Jan 8, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants