dockerfiles: (re)name suse Dockerfile as expected. #999
Conversation
klihub
requested review from
kad,
marquiz,
mythi,
askervin,
jukkar and
fmuyassarov
as code owners
[cherry-picked intel#999/a54f3165] Building native distro packages with 'make packages' expects the distro-specific Dockerfile to have the '-opensuse-leap-$VERSION' suffix when building on opensuse, since this is how the distro names itself in /etc/os-release. (Re)name the Dockerfile to be as expected. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
|
Sorry, does this fix some issue? Seems to work fine for me, e.g. |
Codecov Report
@@ Coverage Diff @@
## master #999 +/- ##
=======================================
Coverage 31.86% 31.86%
=======================================
Files 65 65
Lines 9835 9835
=======================================
Hits 3134 3134
Misses 6411 6411
Partials 290 290 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Yes. Clone the repo on any machine running opensuse and try 'make packages'. It fails without this commit and succeeds with this one present in the tree. |
And the reason is that the distro calls itself opensuse in |
|
Hmm... but you are right that there might be a better/easier fix for that. And I think this might break some (packaging) tests without further changes. |
klihub
force-pushed
the
fixes/opensuse-dockerfile-name
branch
from
a54f316
to
633b1a4
Compare
[cherry-picked intel#999/633b1a4e] Building native distro packages with 'make packages' expects the distro-specific Dockerfile to have the '-opensuse-leap-$VERSION' suffix when building on opensuse, since this is how the distro names itself in /etc/os-release. (Re)name the Dockerfile to be as expected. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Building native distro packages with 'make packages' expects the distro-specific Dockerfile to have the '-opensuse-leap-$VERSION' suffix when building on opensuse, since this is how the distro names itself in /etc/os-release. (Re)name the Dockerfile to be as expected. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
fixes/opensuse-dockerfile-name
branch
from
633b1a4
to
a15dc4a
Compare
[cherry-picked intel#999/a15dc4a8] Building native distro packages with 'make packages' expects the distro-specific Dockerfile to have the '-opensuse-leap-$VERSION' suffix when building on opensuse, since this is how the distro names itself in /etc/os-release. (Re)name the Dockerfile to be as expected. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Updated commits with 2 related fixes/adjustments, one in the docs and another in a packaging test case. |
Building native distro packages with 'make packages' expects the distro-specific Dockerfile to have the '-opensuse-leap-$VERSION' suffix when building on opensuse, since this is how the distro names itself in /etc/os-release. (Re)name the Dockerfile to be as expected.