Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing docstrings to data_sources/curl_source.py #3464

Closed
terriko opened this issue Oct 25, 2023 · 5 comments
Closed

docs: add missing docstrings to data_sources/curl_source.py #3464

terriko opened this issue Oct 25, 2023 · 5 comments
Assignees
Labels
documentation Documentation changes good first issue Good for newcomers hacktoberfest good issue for hacktoberfest participation

Comments

@terriko
Copy link
Contributor

terriko commented Oct 25, 2023

We haven't been entirely consistent about adding python docstrings to every function, and I'd like to start improving the codebase. I'm filing separate tickets for each file I want updated so hacktoberfest folk can claim them more easily -- please only claim one or two at a time.

Here's a tutorial on docstrings in case you're not sure what they are. Basically I want someone to write a short sentence explaining what a function does and have it put at the top of the function in the way that python expects docstrings to look. (You can also do classes and methods.)

This issue is for updating the file foutput_engine/pdfbuilder.py. interrogate (a tool for checking docstrings) says it's missing the following docstrings:

interrogate -vv -i -I -M -C data_sources/curl_source.py

------------------------------ Detailed Coverage -------------------------------

Name Status
curl_source.py
Curl_Source (L25) MISSED
Curl_Source.get_cve_data (L42) MISSED
Curl_Source.fetch_cves (L48) MISSED
Curl_Source.download_curl_vulnerabilities (L59) MISSED
Curl_Source.get_cve_list (L68) MISSED
------------------------------------------------------------- ----------------

You will need to actually read the file and figure out what it does, then describe each function. Feel free to ask questions if you're not sure, or submit a partial fix where you only add docstrings to some functions.

Short tips for new contributors:

  • cve-bin-tool's contributor docs
  • If you've contributed to open source but not this project, you might just want our checklist for a great pull request
  • cve-bin-tool uses https://www.conventionalcommits.org/ style for commit messages, and we have a test that checks the title of your pull request (PR). A good potential title for this one is in the title of this issue.
  • You can make an issue auto close by including a comment "fixes #ISSUENUMBER" in your PR comments where ISSUENUMBER is the actual number of the issue. This "links" the issue to the pull request.

Claiming issues:

  • You do not need to have an issue assigned to you before you work on it. To "claim" an issue either make a linked pull request or comment on the issue saying you'll be working on it.
  • If someone else has already commented or opened a pull request, assume it is claimed and find another issue to work on.
  • If it's been more than 1 week without progress, you can ask in a comment if the claimant is still working on it before claiming it yourself (give them at least 3 days to respond before assuming they have moved on).
@terriko terriko added good first issue Good for newcomers documentation Documentation changes hacktoberfest good issue for hacktoberfest participation labels Oct 25, 2023
@AryanBakliwal
Copy link
Contributor

I’ll be working on this.

@btwshivam
Copy link
Contributor

I want to work on it assign me!

@terriko
Copy link
Contributor Author

terriko commented Oct 26, 2023

@AryanBakliwal spoke first, so I've assigned them this issue!

@terriko
Copy link
Contributor Author

terriko commented Oct 26, 2023

Oh, wait, I've realized that @AryanBakliwal also claimed #3463 . In the interest of sharing out more easy issues, I'm going to leave #3563 assigned to @AryanBakliwal but let @shivam200446 take this one.

@terriko terriko assigned btwshivam and unassigned AryanBakliwal Oct 26, 2023
terriko added a commit that referenced this issue Nov 2, 2023
)

* Update curl_source.py
* chore: blacken cve_bin_tool/data_sources/curl_source.py

---------

Co-authored-by: Terri Oda <terri.oda@intel.com>
@terriko
Copy link
Contributor Author

terriko commented Nov 2, 2023

closed by #3489

@terriko terriko closed this as completed Nov 2, 2023
terriko added a commit to terriko/cve-bin-tool that referenced this issue Nov 16, 2023
intel#3489)

* Update curl_source.py
* chore: blacken cve_bin_tool/data_sources/curl_source.py

---------

Co-authored-by: Terri Oda <terri.oda@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation changes good first issue Good for newcomers hacktoberfest good issue for hacktoberfest participation
Projects
None yet
Development

No branches or pull requests

3 participants