New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(checker): libbpg checker #1237
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1237 +/- ##
==========================================
+ Coverage 76.62% 78.38% +1.76%
==========================================
Files 223 225 +2
Lines 4368 4377 +9
Branches 549 549
==========================================
+ Hits 3347 3431 +84
+ Misses 876 811 -65
+ Partials 145 135 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@peb-peb the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, all of those version patterns look distinctly like pathnames. Does this work on other distro packages or just the one rpm? (It's mergeable either way, but we may want to flag it as being distro-specific the way we did with polarssl)
I was only able to find it for 2 distros (i.e. alt linux and netbsd) from https://pkgs.org/search/?q=libbpg. The pattern was consistent in these two. |
Good enough for me. Let's merge it and if it turns out to be a problem, we can always adjust it later. |
why are the tests not passing? By manually looking at the files, the strings are present. Here is the output from helper script: