Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: group arguments in cli #1340

Merged
merged 5 commits into from
Aug 18, 2021
Merged

fix: group arguments in cli #1340

merged 5 commits into from
Aug 18, 2021

Conversation

imsahil007
Copy link
Contributor

No description provided.

@imsahil007
Copy link
Contributor Author

fix #1337

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021

Codecov Report

Merging #1340 (66c2b86) into main (3ccda67) will increase coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head 66c2b86 differs from pull request most recent head 117dfca. Consider uploading reports for the commit 117dfca to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
+ Coverage   79.31%   79.43%   +0.11%     
==========================================
  Files         271      271              
  Lines        4908     4911       +3     
  Branches      593      593              
==========================================
+ Hits         3893     3901       +8     
+ Misses        866      861       -5     
  Partials      149      149              
Flag Coverage Δ
longtests 79.43% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/cli.py 74.71% <100.00%> (+0.44%) ⬆️
cve_bin_tool/nvd_api.py 85.56% <0.00%> (+5.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ccda67...117dfca. Read the comment docs.

cve_bin_tool/cli.py Outdated Show resolved Hide resolved
cve_bin_tool/cli.py Show resolved Hide resolved
doc/MANUAL.md Outdated Show resolved Hide resolved
doc/MANUAL.md Outdated Show resolved Hide resolved
doc/MANUAL.md Outdated Show resolved Hide resolved
doc/MANUAL.md Outdated

### -m INTERMEDIATE_REPORTS, --merge INTERMEDIATE_REPORTS

This option allows you to merge intermediate reports created using `-a` or `--append`. The output from the merged report produces a report on the console. But you can also use it along with `-f --format` and `-o --output-file` to produce output in other formats. It takes a list of comma-separated filepath.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This option allows you to merge intermediate reports created using `-a` or `--append`. The output from the merged report produces a report on the console. But you can also use it along with `-f --format` and `-o --output-file` to produce output in other formats. It takes a list of comma-separated filepath.
This option allows you to merge intermediate reports created using `-a` or `--append`. The output from the merged report produces a report on the console. But you can also use it along with `-f --format` and `-o --output-file` to produce output in other formats. It takes a list of comma-separated filepaths.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Molkree's got some good text changes as well, but I think this is pretty close to ready other than a bit of wordsmithing. The improved groups should make this much easier to follow.

@@ -73,18 +73,29 @@ def main(argv=None):
+ "\n\nPlease disclose issues responsibly!",
formatter_class=argparse.RawDescriptionHelpFormatter,
)

nvd_database_group = parser.add_argument_group(
"NVD", "Arguments related to NVD Datbase and Cache Configuration"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"NVD", "Arguments related to NVD Datbase and Cache Configuration"
"CVE data download", "Arguments related to NVD Database and Cache Configuration"

We've been kind of assuming that people know (or will look up) what the NVD is, but maybe we could use the heading to give them a hint here.

cve_bin_tool/cli.py Show resolved Hide resolved
doc/MANUAL.md Outdated Show resolved Hide resolved
@@ -660,6 +624,54 @@ indicates that CVEs may be present in the code. A good result here is 0.

The logging modes provide additional fine-grained control for debug information.

## Merge Report Arguments

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Users may wish to create and combine multiple cve-bin-tool reports to track how vulnerability changes over time, how long it takes to fix issues, or other changes between different reports. We have a number of options related to merging report data.

Taking a stab at an intro section with some common usages, mostly for users wondering if they should try out these arguments.

@terriko
Copy link
Contributor

terriko commented Aug 17, 2021

Merging #1273 caused a merge conflict. I believe I've resolved it correctly using the web interface but I'm going to let the tests run before assuming.

@terriko
Copy link
Contributor

terriko commented Aug 18, 2021

Not entirely sure why it failed, in CI (it wasn't black!) so I'm going to try a re-run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants