Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: don't follow symlinks in archives (#1475) #1486

Merged
merged 32 commits into from Dec 28, 2021

Conversation

anthonyharrison
Copy link
Contributor

No description provided.

anthonyharrison and others added 30 commits May 27, 2020 12:55
@terriko
Copy link
Contributor

terriko commented Dec 28, 2021

CI is failing with ModuleNotFoundError: No module named 'setuptools' and I can't see how this could be the fault of the PR, so I'm going to go ahead and re-run CI here.

@codecov-commenter
Copy link

Codecov Report

Merging #1486 (076c67c) into main (d1cb4db) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1486      +/-   ##
==========================================
- Coverage   82.51%   82.39%   -0.13%     
==========================================
  Files         279      279              
  Lines        5445     5447       +2     
  Branches      884      885       +1     
==========================================
- Hits         4493     4488       -5     
- Misses        763      769       +6     
- Partials      189      190       +1     
Flag Coverage Δ
longtests 82.39% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/extractor.py 63.97% <0.00%> (-0.81%) ⬇️
cve_bin_tool/nvd_api.py 82.65% <0.00%> (-5.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1cb4db...076c67c. Read the comment docs.

@terriko
Copy link
Contributor

terriko commented Dec 28, 2021

Well, CI is still failing because of something, but this PR looks fine to me so I'm going to go ahead and merge it.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@terriko terriko merged commit 6f292ef into intel:main Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants